Age | Commit message (Collapse) | Author |
|
Mark some ctors explicit.
Rename GetXFANode to GetXFAObject to match its return type,
since it is cast to node in many places.
BUG=pdfium:384
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1662063002 .
|
|
BUG=pdfium:374
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640233004 .
|
|
BUG=pdfium:378
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1652933002 .
|
|
This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644633003 .
(cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b)
Review URL: https://codereview.chromium.org/1648233002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1647613003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640033002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636873004 .
|
|
Contains additional XFA-specific changes.
Original Review URL: https://codereview.chromium.org/1632143002 .
(cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636503006 .
|
|
BUG=pdfium:367
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1620813003 .
|
|
And a few other nits.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1635853002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1573243003 .
|
|
Small tidying.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1601023004 .
|
|
BUG=pdfium:354
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1580773002 .
|
|
BUG=pdfium:350
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1608593003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1581823002 .
|
|
Inconsisten use of "override".
BUG=pdfium:354
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1577723004 .
|
|
BUG=pdfium:347
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1573893002 .
|
|
BUG=pdfium:348
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579503002 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570893003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572393002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1578003002 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
Review URL: https://codereview.chromium.org/1577503002 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
(cherry picked from commit 14f39950451bb9c2a11fbc7173fd47367410f80f)
Review URL: https://codereview.chromium.org/1576033002 .
|
|
Also remove useless files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570743002 .
|
|
The reference count didn't increase when a
computed style object was referred.
BUG=pdfium:281
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1527263002 .
|
|
Also do some cleanups in affected files.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
(cherry picked from commit d794d34b5deb6ad691c19af758090f9ce46015a3)
Review URL: https://codereview.chromium.org/1566583002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
BUG=pdfium:333
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537413002 .
|
|
BUG=pdfium:328
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1538513002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1521163002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
When some layout items are released, applications should
be notified. It usually happens when there are layout
changes.
BUG=pdfium:303
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1502133002 .
|
|
In some cases, we can use the safe FX_Alloc2D, in others
there's an extra multiplication by the size of the type.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519233002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1505353009 .
|
|
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512283002 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1500313002 .
|
|
BUG=pdfium:324
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1507683010 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1512423003 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508883003 .
|
|
BUG=pdfium:306
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1506423002 .
|
|
The proper way to "wide-stringify" a parameter is by L###arg,
not L"## arg ##", which does no replacement. Also remove dubious
CloneToEvent() method, and make the proper event in the one place
it is called.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1510493005 .
|
|
Re-introduce create methods that actually create the
corresponding impl so we don't have ifaces without impls.
Remove per-subclass Initialize() methods.
Remove unused ctors.
BUG=pdfium:282
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1453473002 .
|
|
This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11.
BUG=
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1502063005 .
|
|
BUG=pdfium:282
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1509203002 .
|
|
This reverts commit 6fa20c60c6ed551af55bfc879668eaac5c237805.
Reason for revert: broke tests
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1507893002 .
|
|
This matches the 3-level parallel hierarchy convention
used elsewhere in FWL. Remove dead code along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1503503003 .
|
|
Uncovered bad casts in a couple of places, replaced with
correct objects.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1503583003 .
|
|
In the process, found two CFWL_ classes that didn't inherit
from the virtual inteface they were allegedly supporting.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1499853003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1500023003 .
|