| Age | Commit message (Collapse) | Author |
|---|
|
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/840903002
|
|
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/841203002
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/742243002
|
|
Includes fixes to XFA specific warnings -- benign truncations.
Bug https://code.google.com/p/pdfium/issues/detail?id=104
was filed to track changing types to avoid some truncations.
Resolve all but two VC++ build warnings in pdfium.
pdfium builds on Win32 have about 85 warnings (250 in the XFA
branch, totaling over 480 lines!), mostly from four lines in
a header file and a warning that should be disabled. This
change resolves all but two of them and turns on
warning-as-errors. Bugs have been filed for the two
remaining warnings:
https://code.google.com/p/pdfium/issues/detail?id=100
the 64-bit warnings:
https://code.google.com/p/pdfium/issues/detail?id=101
and the Linux warnings:
https://code.google.com/p/pdfium/issues/detail?id=102
The fix to the double->float truncation bugs will also
improve code-generation.
R=bo_xu@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/792953005
BUG= https://code.google.com/p/pdfium/issues/detail?id=100
Review URL: https://codereview.chromium.org/834413002
|
|
FX_WSTRC is only valid on arrays, not pointers. In this code it was
being passed a pointer to a URL. This was found when integrating a
change to FX_WSTRC that disallows pointer arguments.
The consequence of this bug is that the URL will end up with incorrect
lengths. It will be one character long in 32-bit builds, and three
characters long in 64-bit builds (sizeof(WCHAR*)-1).
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/831293002
|
|
FX_WSTRC is only valid on arrays, not pointers. In five places it was
being passed a pointer, which leads to incorrect string objects being
created. This was found when integrating a change to FX_WSTRC that
disallows pointer arguments.
The consequence of this bug is that five XML strings (quot, amp,
apos, lt, and gt) will all end up with incorrect lengths. They
will all be one character long in 32-bit builds, and three characters
long in 64-bit builds (sizeof(WCHAR*)-1).
Also removed some unneeded casts and marked some arrays as const.
Fixing this is necessary in order to allow landing of
https://codereview.chromium.org/818193004/
Testing this was attempted by using the xfa branch of pdfium in
Chrome:
cd third_party\pdfium
git checkout xfa
However even without these changes this caused a CHECK failure in
V8::InitializePlatform due to double initialization, so the fix
has not been tested, but is clearly an improvement.
BUG= https://code.google.com/p/pdfium/issues/detail?id=96
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/826573003
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/720323008
|
|
TBR=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/798723003
|
|
Previously no big integer support in Pdfium and XFA.
The PDF417 barcode functionality could not work properly.
BUG=https://code.google.com/p/pdfium/issues/detail?id=98
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/777553002
|
|
BUG= https://code.google.com/p/pdfium/issues/detail?id=89
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/786523004
|
|
Follow-up to work on (wide) string literals.
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/751113003
|
|
Using an incomplete type here avoids casting later on, and allows the
debugger to more easily dig through these data structures.
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/766183009
|
|
One table is also reformatted to put one entry per line for readability.
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/749273003
|
|
BUG=431770
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/728993002
|
|
61750 for dateField input "aaa" not dislpay;
update font map;
|
|
|
