summaryrefslogtreecommitdiff
path: root/xfa
AgeCommit message (Collapse)Author
2016-11-23More unique_ptrs in CXFA_FMParse::ParseForeachExpression and avoid leaknpm
Commit a31098417852bdf13e693a6e0913e0706cf94098 accidentally caused a leak. Replaced pointers with unique_ptr to prevent this from happening. BUG=664891 Review-Url: https://codereview.chromium.org/2528543003
2016-11-23Remove DataProvider from CFWL_WidgetPropertieschromium/2931chromium/2930dsinclair
This CL removes the generic DataProvider code from CFWL_WidgetProperties and adds the specific providers to the two classes that require them. Review-Url: https://codereview.chromium.org/2527683002
2016-11-23Remove IFWL_CombobBox::DataProviderDan Sinclair
The height value returned is always 0. This CL removes the plumbing and uses the 0 value directly. R=npm@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/2525003002 .
2016-11-23Remove listbox providers and build into listboxDan Sinclair
This CL removes the IFWL_ListBox::DataProvider and builds the data storage for the list directly into IFWL_ListBox. This removes the need for the provider in CFWL_ComboBox and CFWL_ListBox. Change-Id: I74c2286757a0b73083908f1cc630a88e7d730fd9 Reviewed-on: https://pdfium-review.googlesource.com/2050 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
2016-11-23Remove plumbing for today valuedsinclair
The calendar always sets today to 2011/01/01. This Cl removes the various DataProviders needed to plumb this value and just sets it where needed. Review-Url: https://codereview.chromium.org/2524993002
2016-11-23Make Update and DrawWidget pure virtualdsinclair
These methods should be in all implementations, make them pure virtual to make that required. Review-Url: https://codereview.chromium.org/2525703004
2016-11-22Rename IFWL_App to CFWL_Appdsinclair
This class is not an interface but a concrete implementation. Rename to match. Review-Url: https://codereview.chromium.org/2521303002
2016-11-22Rename IFWL_Timer and IFWL_TimerInfodsinclair
These twho files are not interfaces. Renamed to be CFWL to signify they are concrete implementations. Review-Url: https://codereview.chromium.org/2526513002
2016-11-22Rename common methods between ifwl and cfwl.dsinclair
This CL renames some methods in IFWL which have the same name as the CFWL methods but the CFWL methods are not proxy methods. Review-Url: https://codereview.chromium.org/2520413002
2016-11-21Remove the GetCaption dataprovider methodchromium/2928dsinclair
This method mostly returns L"". In the one case where it returns something different the value is substituted into the callsite. The IFWL_Tooltip class was using the caption, but it is not currently being used. Removed as well. Review-Url: https://codereview.chromium.org/2522663002
2016-11-21Remove FwlEventMaskdsinclair
The only value being set from the enum was the All Mask. This was always set through the default value in the methods. This Cl removes the mask code completely and updates surrounding code as needed. Review-Url: https://codereview.chromium.org/2515243003
2016-11-21Split fwl/core class pt II.dsinclair
Split classes in FWL to be single class per file. In the case of data providers which added no new methods, removed and used the IFWL_Widget::DataProvider directly. Review-Url: https://codereview.chromium.org/2520063002
2016-11-21Clean up CFGAS_GEFontnpm
Removed some unused method, named files properly, cleaned up a bit. Review-Url: https://codereview.chromium.org/2524493002
2016-11-21Make CPDF_Stream() take unique_ptr's to its dictionary.tsepez
Review-Url: https://codereview.chromium.org/2520493002
2016-11-21Remove customized layout flag from FWLdsinclair
The Customized Layout flag in FWL is always false. Removed the flag and updated the code as needed. Review-Url: https://codereview.chromium.org/2520023002
2016-11-21Update SetThemeColor and SetThemeDatadsinclair
The SetThemeColor and SetThemeData methods are always called with a parameter of 0. This Cl removes the parameter and updates the code as needed. Review-Url: https://codereview.chromium.org/2521683002
2016-11-21Remove FWL_GetThemeColordsinclair
The FWL_GetThemeColor method is always called with 0 which will return 0. This CL removes the calls and replaces the callsites with 0 as needed. Review-Url: https://codereview.chromium.org/2523453002
2016-11-21Remove FWL_GetThemeLayoutdsinclair
FWL_GetThemeLayout is only called in one place with 0 as the parameter. This can never be true, so replace it with false at the callsite. Review-Url: https://codereview.chromium.org/2521673002
2016-11-21Remove theme id from themeprovidersdsinclair
The theme ID is never set, so it's always 0. This CL removes the Set/Get methods and updates the code to use 0 in place of m_dwThemeId. Review-Url: https://codereview.chromium.org/2519113002
2016-11-21Fixup lint flags.Dan Sinclair
The -build/include setting was masking out build/include_what_you_use. This CL restores them, fixes any build errors, and adds NOLINT as needed. As well, the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd. lint cleanups Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f Reviewed-on: https://pdfium-review.googlesource.com/2030 Reviewed-by: Tom Sepez <tsepez@chromium.org>
2016-11-21Split fwl/core class pt I.dsinclair
Split classes in FWL to be single class per file. In the case of data providers which added no new methods, removed and used the IFWL_DataProvider directly. Review-Url: https://codereview.chromium.org/2506253004
2016-11-21Remove unused FWL_WGTSTYLE_Icondsinclair
The FWL_WGTSTYLE_Icon flag is never set. This CL removes it and the supporting Icon code from IFWL_Form. Review-Url: https://codereview.chromium.org/2516433003
2016-11-21Remove unset FWL_WGTSTYLE_NarrowCaptiondsinclair
This CL removes the flag which never appears to be set and the supporting code for captions in IFWL_Form as they are never used. Review-Url: https://codereview.chromium.org/2507283003
2016-11-21Remove unset FWL_WGTSTYLE_Captiondsinclair
This flag does not appear to be applied to the styles, so the supporting code will never be executed. Review-Url: https://codereview.chromium.org/2502233005
2016-11-21Remove unread m_InfoStart from IFWL_Form.dsinclair
The m_InfoStart variable has values set but never read. Removed. Review-Url: https://codereview.chromium.org/2513673002
2016-11-21Remove form resize typedsinclair
The m_eResizeType variable is set but never read. Removed. Review-Url: https://codereview.chromium.org/2508263002
2016-11-18Make CPDF_Dictionary use unique pointers.chromium/2926tsepez
Some changes were required to match underlying ctors as invoked by the templated methods. Many release() calls go away, a few WrapUniques() are introduced to avoid going deeper into other code. Review-Url: https://codereview.chromium.org/2510223002
2016-11-18Add unit test for CXFA_FileRead.tsepez
The FileRead's return convention is being modified at https://codereview.chromium.org/2430743003/, so first provide a test of the old behaviour. Fix some issues with null dictionaries as provided by the CPDF_Stream default ctor along the way. Review-Url: https://codereview.chromium.org/2517513003
2016-11-18Clean up CFGAS_FontMgrchromium/2925npm
Review-Url: https://codereview.chromium.org/2512213002
2016-11-17Remove IFWL_ToolTipDPdsinclair
There are no longer any classes which implement this interface. Remove interface. Review-Url: https://codereview.chromium.org/2511183002
2016-11-17Remove FWL_EVENT_DEF macrodsinclair
No longer used. Review-Url: https://codereview.chromium.org/2506153003
2016-11-17Unify the three CFWL_EventType::SelectChange classes.dsinclair
This CL removes the ListBox SelectChange class as it is never processed. The other two have been unified into a single classs. Review-Url: https://codereview.chromium.org/2509283003
2016-11-17Create CFWL_EvtEditChangeddsinclair
This CL creates a generic event for CFWL_EventType::EditChanged and uses it in the ComboBox and DateTimePicker. None of the params from the custom events were used so they have been removed. Review-Url: https://codereview.chromium.org/2511813002
2016-11-17Remove the CFWL_EventType::DrawItemdsinclair
The ListBox DrawItems event is caught by the ComboBox which converts the event into a ComboBox DrawItems event which is never processed. Removed both. Review-Url: https://codereview.chromium.org/2510123002
2016-11-17Convert CFWL_EvtSpbClick to CFWL_EvtClickdsinclair
The m_bUp flag of CFWL_EvtSpbClick is never used after being set. Remove the flag and replace CFWL_EvtSpbClick with CFWL_EvtClick. Review-Url: https://codereview.chromium.org/2511803002
2016-11-17Convert single use EventTypes to class files.dsinclair
This moves the remaining EventType class definitions to there own files where the EventType only has a single implementation. Review-Url: https://codereview.chromium.org/2508203002
2016-11-17Remove events which are not processeddsinclair
The DropDown, HoverChanged and CloseUp events are created and thrown but are not caught for processing anywhere. Removed. Review-Url: https://codereview.chromium.org/2509733006
2016-11-17Move the IFWL_Edit Events out of ifwl_edit.hdsinclair
This Cl moves the edit events to actual class files and renames to drop the Edt from the names. Review-Url: https://codereview.chromium.org/2515463002
2016-11-17Remove SelfAdaption codedsinclair
Nothing listens for CFWL_Event::PreSelfAdaption events and nothing sets the HSelfAdaption or VSelfAdaption flags into IFWL_Edit. Removing code. Review-Url: https://codereview.chromium.org/2514443002
2016-11-16Split the common event classes out to files.dsinclair
This CL splits the common event classes out to individual files instead of being created by the macro. The other classes will be split out in subsequent CLs. Review-Url: https://codereview.chromium.org/2507713003
2016-11-16Remove ref counting from CFWL_Eventdsinclair
CFWL_Event has no Retain method, just a Release method. So, it's essentially just a delete call whenever used. This CL removes the Release method and turns the one usage into a unique_ptr. Review-Url: https://codereview.chromium.org/2509863002
2016-11-16Move the message definitions to their own files.chromium/2923dsinclair
Currently the CFWL messages are created by a macro in the CFWL_Message header file. This Cl splits out the class to their own files and writes them directly instead of using the macro. Review-Url: https://codereview.chromium.org/2510823003
2016-11-16Continue formatting fwl/coredsinclair
Review-Url: https://codereview.chromium.org/2510793003
2016-11-16Continue formatting fwl/coredsinclair
Review-Url: https://codereview.chromium.org/2506083002
2016-11-16Continue fwl/core nit cleanup.dsinclair
Review-Url: https://codereview.chromium.org/2501033005
2016-11-16Continue nit cleanup in fwl/coredsinclair
Review-Url: https://codereview.chromium.org/2506493003
2016-11-16Cleaning up nits in fwl/core files.chromium/2922dsinclair
This Cl cleans up the nits in the first set of cfwl_* files. The unused Event and Message classes are removed. Review-Url: https://codereview.chromium.org/2505703003
2016-11-15Cleanup cfwl_* files.dsinclair
This Cl cleans up the visibility, method usage and return values in the remaining CFWL files. Review-Url: https://codereview.chromium.org/2498163002
2016-11-15Cleaning methods and visibility in cfwl_* files.dsinclair
First pass at cleaning up visibility, return values and const'ness of cfwl_* class. Review-Url: https://codereview.chromium.org/2501743002
2016-11-14Cleanup fwl_* classes and cfx_* classes in fwl.dsinclair
This CL cleans up the classes in the fwl_* and cfx_* files in fwl/core. Review-Url: https://codereview.chromium.org/2503513002