Age | Commit message (Collapse) | Author |
|
This CL fixes and enables:
* readability/namespace
* readability/multiline_string
* readability/multiline_comment
* readability/inheritance
* readability/function
* readability/braces
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1747123002 .
|
|
Helps with transparency. Also remove default args and
use override consistently in the affected methods.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1751093002 .
|
|
This is never defined in the current code base. Remove.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1751913002 .
|
|
This flag is always defined, remove conditional code and flag.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1752503004 .
|
|
The _XFA_EMB flag is never defined, remove conditionals.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1751033002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1745243002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1745023003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1746053003 .
|
|
Change a couple int32_t's to size_t in order to fix warnings on OSX.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1747793002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749703002 .
|
|
The _XFA_LAYOUTITEM_ProcessCACHE_ define is always set and the
_XFA_LAYOUTITEM_MAPCACHE_ define is never set.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1750623002 .
|
|
This code is dead, remove it.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1746793002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749793002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749783002 .
|
|
This value is never set and never read. Removing it fixes a series of warnings
when building on OSX as g_XFAElementPropertyIndex does not initialize the
value.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1744893002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1746803002 .
|
|
This CL removes duplicate forward declarations, removes extraneous declarations
and adds a couple of missing declarations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1741003002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1727273007 .
|
|
Grepping for FX_BOOL and |==| on the same line gives
a very strong clue that the expression won't be out
of range of the |bool| type iteself.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736323003 .
|
|
They buy us nothing and obfuscate the logic.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740223002 .
|
|
Do some cleanups along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1732223002 .
|
|
This does not appear to ever be defined. There are a few methods which end up
being empty after this change, removed those and their callers as well.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1736133002 .
|
|
Remove the define and the #ifdef checks.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1741543002 .
|
|
The fde_memory.h include wasn't needed. This CL converts the
FDE_NewWith and FDE_DeleteWith calls to their FXTARGET_
counterparts.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736053002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740863002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1740643002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735353002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1735333002 .
|
|
And other nearby dead code.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1740613002 .
|
|
Add default ctor so we don't have to zero these out.
Also, make CFX_VTemplate simpler.
Also, remove the Set() method in favor of assignment.
Also, remove CFX_FloatPoint define.
Also, remove unused (and wrong) CFX_VTemplate methods.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733523003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740783002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740633004 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1738983002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
Also fix IWYU in various fxbarcode headers.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1734823002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1729983002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1726373002 .
|
|
Missed one remaining use of FGAS_LPCFONTUSB.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735623003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735663002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730893003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1731483004 .
|
|
Two files become completely empty and are deleted.
Oddly, they never appeared in gyp/gn files.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1724303002 .
|
|
This header just includes other headers, remove file and callsites.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1734683002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733693002 .
|
|
This CL enables several of the diabled whitelist/* lint checks.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730553002 .
|
|
Also remove another CFX_ArrayTemplate usage.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730753002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730713002 .
|
|
This is just a wrapper for (a) / (b). Inline the divide.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1727793002 .
|
|
This define just multiples the two parameters together. Inline the *'s.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1729613003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1726803002 .
|