summaryrefslogtreecommitdiff
path: root/xfa
AgeCommit message (Collapse)Author
2016-03-01Fix and enable lint checks.Dan Sinclair
This CL fixes and enables: * readability/namespace * readability/multiline_string * readability/multiline_comment * readability/inheritance * readability/function * readability/braces R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1747123002 .
2016-03-01Replace FX_LPCRECT typedef with underlying typesTom Sepez
Helps with transparency. Also remove default args and use override consistently in the affected methods. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1751093002 .
2016-03-01Remove FX_NUM_DOUBLEDan Sinclair
This is never defined in the current code base. Remove. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1751913002 .
2016-03-01Remove XFA_PARSE_HAS_LINEIDENTIFIERDan Sinclair
This flag is always defined, remove conditional code and flag. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1752503004 .
2016-03-01Remove _XFA_EMBDan Sinclair
The _XFA_EMB flag is never defined, remove conditionals. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1751033002 .
2016-02-29Pass rect by const reference in SetClip_Rect().Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1745243002 .
2016-02-29Remove xfa_fm2js.h and IWYU.Dan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1745023003 .
2016-02-29Remove foxitlib.h and foxitxfa.h and IWYU.Dan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1746053003 .
2016-02-29Using size_t to silence warnings.Dan Sinclair
Change a couple int32_t's to size_t in order to fix warnings on OSX. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1747793002 .
2016-02-29Remove fgas_base.h and IWYUDan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1749703002 .
2016-02-29Remove _XFA_LAYOUTITEM_* defines.Dan Sinclair
The _XFA_LAYOUTITEM_ProcessCACHE_ define is always set and the _XFA_LAYOUTITEM_MAPCACHE_ define is never set. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1750623002 .
2016-02-29Remove #if 0 code.Dan Sinclair
This code is dead, remove it. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1746793002 .
2016-02-29Remove _FX_USEGASFONTMGR_ as it is always definedDan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1749793002 .
2016-02-29Remove #ifdef _FXEMB as it is not definedDan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1749783002 .
2016-02-29Remove wParentIndex from XFA_ELEMENTHIERARCHY.Dan Sinclair
This value is never set and never read. Removing it fixes a series of warnings when building on OSX as g_XFAElementPropertyIndex does not initialize the value. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1744893002 .
2016-02-29Remove _FXLIB_NEW_VERSION_ as it is always defined.Dan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1746803002 .
2016-02-27Cleanup forward declarations.dan sinclair
This CL removes duplicate forward declarations, removes extraneous declarations and adds a couple of missing declarations. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1741003002 .
2016-02-26Fix windows build broken at 007e6c0Tom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1727273007 .
2016-02-26Remove some FX_BOOLsTom Sepez
Grepping for FX_BOOL and |==| on the same line gives a very strong clue that the expression won't be out of range of the |bool| type iteself. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1736323003 .
2016-02-26Replace or remove _FX control-flow definesTom Sepez
They buy us nothing and obfuscate the logic. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1740223002 .
2016-02-25Use std::lower_bound() in a couple places.Lei Zhang
Do some cleanups along the way. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1732223002 .
2016-02-25Remove FDE_USEFORMATBLOCK.Dan Sinclair
This does not appear to ever be defined. There are a few methods which end up being empty after this change, removed those and their callers as well. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1736133002 .
2016-02-25_XFA_VERIFY_Checksum is always defined.Dan Sinclair
Remove the define and the #ifdef checks. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1741543002 .
2016-02-25Remove fde_mem.hDan Sinclair
The fde_memory.h include wasn't needed. This CL converts the FDE_NewWith and FDE_DeleteWith calls to their FXTARGET_ counterparts. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1736053002 .
2016-02-25Remove fgas.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1740863002 .
2016-02-25Use std::unique_ptr in CXFA_FMParse.Lei Zhang
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1740643002 .
2016-02-25Remove fde.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1735353002 .
2016-02-25Make CXFA_Node::GetMeasure() and friends const.Lei Zhang
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1735333002 .
2016-02-25Remove set but unsed variables.Lei Zhang
And other nearby dead code. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1740613002 .
2016-02-25Make CFX_PSVTemplate simpler.Tom Sepez
Add default ctor so we don't have to zero these out. Also, make CFX_VTemplate simpler. Also, remove the Set() method in favor of assignment. Also, remove CFX_FloatPoint define. Also, remove unused (and wrong) CFX_VTemplate methods. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1733523003 .
2016-02-25Replace various *_MAX_VALUE macros with numeric_limits.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1740783002 .
2016-02-25Fix mac build, part 2.dan sinclair
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1740633004 .
2016-02-25Fix Mac Build, missing include.Dan Sinclair
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1738983002 .
2016-02-25Remove include only fwl.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1735833003 .
2016-02-24Get rid of CBC_AutoPtr and use std::unique_ptr instead.Lei Zhang
Also fix IWYU in various fxbarcode headers. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1734823002 .
2016-02-24Remove foo != NULL checks in xfa/src/fxfa.Lei Zhang
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1729983002 .
2016-02-24Remove foo != NULL checks in xfa/src/fxbarcode.Lei Zhang
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1726373002 .
2016-02-24Fix windows build broken at ea208f2.Tom Sepez
Missed one remaining use of FGAS_LPCFONTUSB. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1735623003 .
2016-02-24Moar _CAPS work, part 5Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1735663002 .
2016-02-24Remove include only barcode.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1730893003 .
2016-02-24Moar _CAPS naming, part 4Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1731483004 .
2016-02-24_FXPLUS is never defined.Tom Sepez
Two files become completely empty and are deleted. Oddly, they never appeared in gyp/gn files. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1724303002 .
2016-02-24Remove fxv8.hDan Sinclair
This header just includes other headers, remove file and callsites. R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1734683002 .
2016-02-24Remove xfa_common.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1733693002 .
2016-02-24Fixing whitespace lint errors.Dan Sinclair
This CL enables several of the diabled whitelist/* lint checks. R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1730553002 .
2016-02-23Simplify CFDE_CSSStyleSelector::SortRulesTo().Lei Zhang
Also remove another CFX_ArrayTemplate usage. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1730753002 .
2016-02-23Moar _CAPS work, part 3.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1730713002 .
2016-02-23Remove FXSYS_Div.Dan Sinclair
This is just a wrapper for (a) / (b). Inline the divide. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1727793002 .
2016-02-23Remove FXSYS_Mul.Dan Sinclair
This define just multiples the two parameters together. Inline the *'s. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1729613003 .
2016-02-23Remove more _CAPS namesTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1726803002 .