From 1763f62972a3ebf080f645899a8de79b00dbfb23 Mon Sep 17 00:00:00 2001 From: tsepez Date: Wed, 18 May 2016 13:07:00 -0700 Subject: Remove Release() from CFX_SAXReader Review-Url: https://codereview.chromium.org/1991993002 --- xfa/fgas/xml/fgas_sax.h | 1 - xfa/fxfa/app/xfa_checksum.cpp | 6 ++---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/xfa/fgas/xml/fgas_sax.h b/xfa/fgas/xml/fgas_sax.h index 57ff6b2470..92440c3b59 100644 --- a/xfa/fgas/xml/fgas_sax.h +++ b/xfa/fgas/xml/fgas_sax.h @@ -91,7 +91,6 @@ class CFX_SAXReader { CFX_SAXReader(); ~CFX_SAXReader(); - void Release() { delete this; } int32_t StartParse(IFX_FileRead* pFile, uint32_t dwStart = 0, uint32_t dwLen = -1, diff --git a/xfa/fxfa/app/xfa_checksum.cpp b/xfa/fxfa/app/xfa_checksum.cpp index 1641816550..fab14c9b17 100644 --- a/xfa/fxfa/app/xfa_checksum.cpp +++ b/xfa/fxfa/app/xfa_checksum.cpp @@ -161,10 +161,8 @@ FX_BOOL CXFA_ChecksumContext::UpdateChecksum(IFX_FileRead* pSrcFile, } void CXFA_ChecksumContext::FinishChecksum() { - if (m_pSAXReader) { - m_pSAXReader->Release(); - m_pSAXReader = NULL; - } + delete m_pSAXReader; + m_pSAXReader = nullptr; if (m_pByteContext) { uint8_t digest[20]; FXSYS_memset(digest, 0, 20); -- cgit v1.2.3