From 1d78f4dd34637bf9a16411f64816ef87cb128165 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 22 Oct 2018 20:17:38 +0000 Subject: Remove pdfium_diff target from pdf_is_standalone block. Allows it to be built as part of a chromium checkout so that the official coverage tools may invoke it as part of the coverage generation scripts. Change-Id: I8ed49f789a6a7e7eaa8ece4ef068295b0942cc45 Reviewed-on: https://pdfium-review.googlesource.com/c/44490 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- BUILD.gn | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index c19e2227a7..53a633baf8 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -340,6 +340,21 @@ test("pdfium_embeddertests") { } } +executable("pdfium_diff") { + testonly = true + sources = [ + "testing/image_diff/image_diff.cpp", + ] + deps = [ + ":pdfium", + "testing/image_diff", + "//build/win:default_exe_manifest", + ] + configs -= [ "//build/config/compiler:chromium_code" ] + configs += [ "//build/config/compiler:no_chromium_code" ] + configs += [ ":pdfium_core_config" ] +} + if (pdf_is_standalone) { jumbo_source_set("samples") { testonly = true @@ -348,21 +363,6 @@ if (pdf_is_standalone) { ] } - executable("pdfium_diff") { - testonly = true - sources = [ - "testing/image_diff/image_diff.cpp", - ] - deps = [ - ":pdfium", - "testing/image_diff", - "//build/win:default_exe_manifest", - ] - configs -= [ "//build/config/compiler:chromium_code" ] - configs += [ "//build/config/compiler:no_chromium_code" ] - configs += [ ":pdfium_core_config" ] - } - group("fuzzers") { testonly = true deps = [ @@ -374,13 +374,13 @@ if (pdf_is_standalone) { group("pdfium_all") { testonly = true deps = [ + ":pdfium_diff", ":pdfium_embeddertests", ":pdfium_unittests", ] if (pdf_is_standalone) { deps += [ ":fuzzers", - ":pdfium_diff", ":samples", ] } -- cgit v1.2.3