From 20582f797f3fdc6308141dbed5eed7d3f84619c9 Mon Sep 17 00:00:00 2001 From: Artem Strygin Date: Tue, 26 Jun 2018 16:28:48 +0000 Subject: Add test which verify, that "Info" from linearized doc is correctly saved. Change-Id: Ib0ee1c2b0a2def650711c87b4eb04a9f88470944 Reviewed-on: https://pdfium-review.googlesource.com/35550 Commit-Queue: Art Snake Reviewed-by: dsinclair --- core/fpdfapi/edit/cpdf_creator_embeddertest.cpp | 66 +++++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp b/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp index f8520c4238..2d431b8424 100644 --- a/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp +++ b/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp @@ -13,8 +13,47 @@ #include "public/fpdf_edit.h" #include "public/fpdfview.h" #include "testing/embedder_test.h" +#include "testing/fake_file_access.h" #include "testing/gmock/include/gmock/gmock-matchers.h" #include "testing/gtest/include/gtest/gtest.h" +#include "testing/utils/path_service.h" + +namespace { + +class FileAccess : public FPDF_FILEACCESS { + public: + explicit FileAccess(const std::string& file_name) { + std::string file_path; + if (!PathService::GetTestFilePath(file_name, &file_path)) + return; + + file_contents_ = GetFileContents(file_path.c_str(), &file_length_); + if (!file_contents_) + return; + + m_FileLen = static_cast(file_length_); + m_GetBlock = SGetBlock; + m_Param = this; + } + + private: + int GetBlockImpl(unsigned long pos, unsigned char* pBuf, unsigned long size) { + memcpy(pBuf, file_contents_.get() + pos, size); + return size; + } + + static int SGetBlock(void* param, + unsigned long pos, + unsigned char* pBuf, + unsigned long size) { + return static_cast(param)->GetBlockImpl(pos, pBuf, size); + } + + size_t file_length_; + std::unique_ptr file_contents_; +}; + +} // namespace class CPDF_CreatorEmbedderTest : public EmbedderTest {}; @@ -62,3 +101,30 @@ TEST_F(CPDF_CreatorEmbedderTest, BUG_873) { std::string data_after_second_id = saved_data.substr(trailer_continuation); EXPECT_THAT(data_after_second_id, testing::StartsWith(">]>>\r\n")); } + +TEST_F(CPDF_CreatorEmbedderTest, SaveLinearizedInfo) { + FileAccess file_acc("linearized.pdf"); + FakeFileAccess fake_acc(&file_acc); + + avail_ = FPDFAvail_Create(fake_acc.GetFileAvail(), fake_acc.GetFileAccess()); + while (PDF_DATA_AVAIL != + FPDFAvail_IsDocAvail(avail_, fake_acc.GetDownloadHints())) { + fake_acc.SetRequestedDataAvailable(); + } + + document_ = FPDFAvail_GetDocument(avail_, nullptr); + ASSERT_TRUE(document_); + + // Load second page, to parse additional crossref sections. + while (PDF_DATA_AVAIL != + FPDFAvail_IsPageAvail(avail_, 1, fake_acc.GetDownloadHints())) { + fake_acc.SetRequestedDataAvailable(); + } + // Simulate downloading of whole file. + fake_acc.SetWholeFileAvailable(); + // Save document. + EXPECT_TRUE(FPDF_SaveAsCopy(document_, this, 0)); + const std::string saved_doc = GetString(); + + EXPECT_THAT(saved_doc, ::testing::HasSubstr("/Info")); +} -- cgit v1.2.3