From 29b708e7af32de30d946b4bb609b390187987cb5 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 12 Oct 2018 17:03:10 +0000 Subject: Mark the bigint target as XFA only. Depend on it directly from the only user, fxbarcode. Change-Id: I303dc7b0e713d683257fb3d893e74fdd40ac2046 Reviewed-on: https://pdfium-review.googlesource.com/c/43939 Reviewed-by: Henrique Nakashima Commit-Queue: Lei Zhang --- BUILD.gn | 2 +- third_party/BUILD.gn | 39 ++++++++++++++++++++------------------- xfa/DEPS | 1 - 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 8a65f06b27..3e268ddafe 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -200,7 +200,6 @@ jumbo_static_library("pdfium") { ":fxge", ":fxjs", ":pwl", - "third_party:bigint", "third_party:pdfium_base", "third_party:skia_shared", ] @@ -1815,6 +1814,7 @@ if (pdf_enable_xfa) { ] deps = [ ":fxcrt", + "third_party:bigint", ] configs += [ ":pdfium_core_config" ] } diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn index 674a847942..c66ae9e34c 100644 --- a/third_party/BUILD.gn +++ b/third_party/BUILD.gn @@ -10,7 +10,6 @@ import("../pdfium.gni") group("third_party") { deps = [ - ":bigint", ":pdfium_base", ":skia_shared", ] @@ -23,24 +22,26 @@ config("pdfium_third_party_config") { configs = [ "..:pdfium_common_config" ] } -source_set("bigint") { - configs -= [ "//build/config/compiler:chromium_code" ] - configs += [ - "//build/config/compiler:no_chromium_code", - ":pdfium_third_party_config", - ] - sources = [ - "bigint/BigInteger.cc", - "bigint/BigInteger.hh", - "bigint/BigIntegerLibrary.hh", - "bigint/BigIntegerUtils.cc", - "bigint/BigIntegerUtils.hh", - "bigint/BigUnsigned.cc", - "bigint/BigUnsigned.hh", - "bigint/BigUnsignedInABase.cc", - "bigint/BigUnsignedInABase.hh", - "bigint/NumberlikeArray.hh", - ] +if (pdf_enable_xfa) { + source_set("bigint") { + configs -= [ "//build/config/compiler:chromium_code" ] + configs += [ + "//build/config/compiler:no_chromium_code", + ":pdfium_third_party_config", + ] + sources = [ + "bigint/BigInteger.cc", + "bigint/BigInteger.hh", + "bigint/BigIntegerLibrary.hh", + "bigint/BigIntegerUtils.cc", + "bigint/BigIntegerUtils.hh", + "bigint/BigUnsigned.cc", + "bigint/BigUnsigned.hh", + "bigint/BigUnsignedInABase.cc", + "bigint/BigUnsignedInABase.hh", + "bigint/NumberlikeArray.hh", + ] + } } if (pdf_bundle_freetype) { diff --git a/xfa/DEPS b/xfa/DEPS index 0442a61e7d..dba1791d5f 100644 --- a/xfa/DEPS +++ b/xfa/DEPS @@ -1,7 +1,6 @@ include_rules = [ '+core', '+fxbarcode', - '+third_party/bigint', # xfa/fwl should be standalone. https://crbug.com/pdfium/507 '-xfa/fwl', -- cgit v1.2.3