From 2c15639637cc9908751fee21019cf3c4a8c60732 Mon Sep 17 00:00:00 2001 From: Artem Strygin Date: Tue, 5 Jun 2018 13:18:58 +0000 Subject: Remove useless code. Change-Id: I68bd9004cb034df749625f4c83072b08d33202e4 Reviewed-on: https://pdfium-review.googlesource.com/17730 Commit-Queue: Art Snake Reviewed-by: dsinclair --- core/fpdfapi/parser/cpdf_data_avail.cpp | 18 +++++------------- core/fpdfapi/parser/cpdf_data_avail.h | 4 +--- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/core/fpdfapi/parser/cpdf_data_avail.cpp b/core/fpdfapi/parser/cpdf_data_avail.cpp index 719169af72..f1a5d0c143 100644 --- a/core/fpdfapi/parser/cpdf_data_avail.cpp +++ b/core/fpdfapi/parser/cpdf_data_avail.cpp @@ -80,9 +80,8 @@ CPDF_DataAvail::CPDF_DataAvail( FileAvail* pFileAvail, const RetainPtr& pFileRead, bool bSupportHintTable) - : m_pFileAvail(pFileAvail), - m_pFileRead( - pdfium::MakeRetain(pFileRead, m_pFileAvail)), + : m_pFileRead( + pdfium::MakeRetain(pFileRead, pFileAvail)), m_dwFileLen(m_pFileRead->GetSize()), m_bSupportHintTable(bSupportHintTable) {} @@ -201,7 +200,6 @@ bool CPDF_DataAvail::CheckAndLoadAllXref() { m_dwRootObjNum = m_parser.GetRootObjNum(); m_dwInfoObjNum = m_parser.GetInfoObjNum(); - m_pCurrentParser = &m_parser; m_docStatus = PDF_DATAAVAIL_ROOT; return true; } @@ -287,7 +285,6 @@ bool CPDF_DataAvail::PreparePageItem() { } m_PagesObjNum = pRef->GetRefObjNum(); - m_pCurrentParser = m_pDocument->GetParser(); m_docStatus = PDF_DATAAVAIL_PAGETREE; return true; } @@ -334,7 +331,7 @@ bool CPDF_DataAvail::CheckPage() { size_t iPages = m_PagesArray.size(); for (size_t i = 0; i < iPages; ++i) { std::unique_ptr pPages = std::move(m_PagesArray[i]); - if (pPages && !GetPageKids(m_pCurrentParser, pPages.get())) { + if (pPages && !GetPageKids(pPages.get())) { m_PagesArray.clear(); m_docStatus = PDF_DATAAVAIL_ERROR; return false; @@ -347,12 +344,7 @@ bool CPDF_DataAvail::CheckPage() { return true; } -bool CPDF_DataAvail::GetPageKids(CPDF_Parser* pParser, CPDF_Object* pPages) { - if (!pParser) { - m_docStatus = PDF_DATAAVAIL_ERROR; - return false; - } - +bool CPDF_DataAvail::GetPageKids(CPDF_Object* pPages) { CPDF_Dictionary* pDict = pPages->GetDict(); CPDF_Object* pKids = pDict ? pDict->GetObjectFor("Kids") : nullptr; if (!pKids) @@ -393,7 +385,7 @@ bool CPDF_DataAvail::CheckPages() { return false; } - if (!GetPageKids(m_pCurrentParser, pPages.get())) { + if (!GetPageKids(pPages.get())) { m_docStatus = PDF_DATAAVAIL_ERROR; return false; } diff --git a/core/fpdfapi/parser/cpdf_data_avail.h b/core/fpdfapi/parser/cpdf_data_avail.h index 2a0705d33d..08bb77a23f 100644 --- a/core/fpdfapi/parser/cpdf_data_avail.h +++ b/core/fpdfapi/parser/cpdf_data_avail.h @@ -142,7 +142,7 @@ class CPDF_DataAvail final { CPDF_IndirectObjectHolder* pObjList = nullptr) const; std::unique_ptr GetObject(uint32_t objnum, bool* pExistInFile); - bool GetPageKids(CPDF_Parser* pParser, CPDF_Object* pPages); + bool GetPageKids(CPDF_Object* pPages); bool PreparePageItem(); bool LoadPages(); bool CheckAndLoadAllXref(); @@ -164,7 +164,6 @@ class CPDF_DataAvail final { bool ValidatePage(uint32_t dwPage) const; CPDF_SyntaxParser* GetSyntaxParser() const; - FileAvail* const m_pFileAvail; RetainPtr m_pFileRead; CPDF_Parser m_parser; std::unique_ptr m_pRoot; @@ -192,7 +191,6 @@ class CPDF_DataAvail final { PageNode m_PageNode; std::set m_pageMapCheckState; std::set m_pagesLoadState; - std::set m_SeenPrevPositions; std::unique_ptr m_pHintTables; const bool m_bSupportHintTable; std::map> m_PagesObjAvail; -- cgit v1.2.3