From 3a3a3690bc4c0b8d50756014dbe2ea85f3075fdc Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Thu, 23 Aug 2018 21:12:35 +0000 Subject: Enable warnings for shadowed variables This CL adds in -Wshadow that will throw a warning whenever a variable is being shadowed. BUG=pdfium:1137 Change-Id: I879683fbf2f84c6609cf496308ddadb74c2f26aa Reviewed-on: https://pdfium-review.googlesource.com/41250 Reviewed-by: Henrique Nakashima Commit-Queue: Ryan Harrison --- BUILD.gn | 3 +++ 1 file changed, 3 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index b3a56f70b0..99e71cfbc8 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -72,6 +72,9 @@ config("pdfium_core_config") { cflags = [] configs = [ ":pdfium_common_config" ] defines = [ "V8_DEPRECATION_WARNINGS" ] + if (is_clang) { + cflags += [ "-Wshadow" ] + } if (is_linux) { if (current_cpu == "x64") { defines += [ "_FX_CPU_=_FX_X64_" ] -- cgit v1.2.3