From 3a83fe5cf6cf1c056118531105359fc31615dc7f Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 13 Jul 2018 16:12:01 +0000 Subject: Fix FPDF_ImportNPagesToOne() documentation. FPDF_ImportNPagesToOne() has width/height parameters to indicate the dimensions of pages in the returned PDF. PDF is not a raster-based format, so pixels are not the right unit for page dimensions. Change-Id: Iff5b373a5a020b5822aaa29d2b44f1dbf7a75b13 Reviewed-on: https://pdfium-review.googlesource.com/37810 Reviewed-by: Henrique Nakashima Commit-Queue: Henrique Nakashima --- fpdfsdk/fpdf_ppo.cpp | 2 +- public/fpdf_ppo.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fpdfsdk/fpdf_ppo.cpp b/fpdfsdk/fpdf_ppo.cpp index 8bbae7258d..722070547f 100644 --- a/fpdfsdk/fpdf_ppo.cpp +++ b/fpdfsdk/fpdf_ppo.cpp @@ -546,7 +546,7 @@ class CPDF_NPageToOneExporter : public CPDF_PageOrganizer { // numbers, insert them into the destination document, starting at page 0. // |pageNums| is 1-based. // |destPageSize| is the destination document page dimensions, measured in - // pixels. + // PDF "user space" units. // |numPagesOnXAxis| and |numPagesOnXAxis| together defines how many source // pages fit on one destination page. bool ExportNPagesToOne(const std::vector& pageNums, diff --git a/public/fpdf_ppo.h b/public/fpdf_ppo.h index 7b21aed404..85112696be 100644 --- a/public/fpdf_ppo.h +++ b/public/fpdf_ppo.h @@ -34,8 +34,8 @@ FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV FPDF_ImportPages(FPDF_DOCUMENT dest_doc, // |output_doc| page. // // src_doc - The document to be imported. -// output_width - The output page width measured in pixels. -// output_height - The output page height measured in pixels. +// output_width - The output page width in PDF "user space" units. +// output_height - The output page height in PDF "user space" units. // num_pages_on_x_axis - The number of pages on X Axis. // num_pages_on_y_axis - The number of pages on Y Axis. // -- cgit v1.2.3