From 403d1ad40b3bc8a96a28fc211fff2c106f590ed8 Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Thu, 8 Mar 2018 16:15:08 +0000 Subject: Remove unused constructor Unused. Removed. Change-Id: I493a98b22c343d44834d3648e4ef2fe9978f88b1 Reviewed-on: https://pdfium-review.googlesource.com/28250 Commit-Queue: dsinclair Reviewed-by: Ryan Harrison --- core/fpdfapi/parser/cpdf_parser.h | 3 ++- core/fpdfapi/parser/cpdf_syntax_parser.cpp | 8 ++------ core/fpdfapi/parser/cpdf_syntax_parser.h | 1 - 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/core/fpdfapi/parser/cpdf_parser.h b/core/fpdfapi/parser/cpdf_parser.h index 45b8cb9f2e..08bb901ae6 100644 --- a/core/fpdfapi/parser/cpdf_parser.h +++ b/core/fpdfapi/parser/cpdf_parser.h @@ -198,11 +198,12 @@ class CPDF_Parser { bool InitSyntaxParser(const RetainPtr& file_access); bool ParseFileVersion(); - UnownedPtr m_pDocument; ObjectType GetObjectType(uint32_t objnum) const; ObjectType GetObjectTypeFromCrossRefStreamType( int cross_ref_stream_type) const; + UnownedPtr m_pDocument; + bool m_bHasParsed; bool m_bXRefStream; int m_FileVersion; diff --git a/core/fpdfapi/parser/cpdf_syntax_parser.cpp b/core/fpdfapi/parser/cpdf_syntax_parser.cpp index 66ce1838f2..624bde4ab3 100644 --- a/core/fpdfapi/parser/cpdf_syntax_parser.cpp +++ b/core/fpdfapi/parser/cpdf_syntax_parser.cpp @@ -41,13 +41,9 @@ enum class ReadStatus { Normal, Backslash, Octal, FinishOctal, CarriageReturn }; int CPDF_SyntaxParser::s_CurrentRecursionDepth = 0; CPDF_SyntaxParser::CPDF_SyntaxParser() - : CPDF_SyntaxParser(WeakPtr()) {} + : m_pFileAccess(nullptr), m_pPool(WeakPtr()) {} -CPDF_SyntaxParser::CPDF_SyntaxParser(const WeakPtr& pPool) - : m_pFileAccess(nullptr), m_pPool(pPool) {} - -CPDF_SyntaxParser::~CPDF_SyntaxParser() { -} +CPDF_SyntaxParser::~CPDF_SyntaxParser() = default; bool CPDF_SyntaxParser::GetCharAt(FX_FILESIZE pos, uint8_t& ch) { AutoRestorer save_pos(&m_Pos); diff --git a/core/fpdfapi/parser/cpdf_syntax_parser.h b/core/fpdfapi/parser/cpdf_syntax_parser.h index d3442880bc..50c20fc115 100644 --- a/core/fpdfapi/parser/cpdf_syntax_parser.h +++ b/core/fpdfapi/parser/cpdf_syntax_parser.h @@ -27,7 +27,6 @@ class CPDF_SyntaxParser { enum class ParseType { kStrict, kLoose }; CPDF_SyntaxParser(); - explicit CPDF_SyntaxParser(const WeakPtr& pPool); ~CPDF_SyntaxParser(); void InitParser(const RetainPtr& pFileAccess, -- cgit v1.2.3