From 44b29d13bffa30733ca0e780c71ca867a3e9a033 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Fri, 1 Jun 2018 15:40:13 +0000 Subject: Remove unneeded call to GetNextSiblingWidget The value is stored in a local scope variable at the end of a loop, so is never used. The method is const, so is sideffect free, thus this line has no overall effect. Issue found with Clang Static Analyzer. Change-Id: Ib20c5c121c8464433c6ad6d8e1439b929033d6d6 Reviewed-on: https://pdfium-review.googlesource.com/33530 Reviewed-by: Henrique Nakashima Commit-Queue: Ryan Harrison --- xfa/fwl/cfwl_widgetmgr.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/xfa/fwl/cfwl_widgetmgr.cpp b/xfa/fwl/cfwl_widgetmgr.cpp index 7bae450374..f19479e72b 100644 --- a/xfa/fwl/cfwl_widgetmgr.cpp +++ b/xfa/fwl/cfwl_widgetmgr.cpp @@ -429,7 +429,6 @@ void CFWL_WidgetMgr::DrawChild(CFWL_Widget* parent, pDelegate->OnDrawWidget(pGraphics, widgetMatrix); DrawChild(child, clipBounds, pGraphics, &widgetMatrix); - child = GetNextSiblingWidget(child); } } -- cgit v1.2.3