From 4cafdefd77e29c9d38ad99c266a60ce296137a35 Mon Sep 17 00:00:00 2001 From: weili Date: Fri, 20 May 2016 17:58:06 -0700 Subject: Return no style in GetItemStyles() for item of null pointer The error handling in GetItemStyles() of list box is wrong. -1 is 0xFFFFFFFF in uint32_t, which suggests all the style bits on. This was discovered by a signed/unsigned mismatch warning. BUG=pdfium:29 Review-Url: https://codereview.chromium.org/2005583002 --- xfa/fwl/lightwidget/cfwl_listbox.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xfa/fwl/lightwidget/cfwl_listbox.cpp b/xfa/fwl/lightwidget/cfwl_listbox.cpp index 46433a3198..e8e26f5b52 100644 --- a/xfa/fwl/lightwidget/cfwl_listbox.cpp +++ b/xfa/fwl/lightwidget/cfwl_listbox.cpp @@ -249,7 +249,7 @@ FX_BOOL CFWL_ListBox::CFWL_ListBoxDP::SetItemIndex(IFWL_Widget* pWidget, uint32_t CFWL_ListBox::CFWL_ListBoxDP::GetItemStyles(IFWL_Widget* pWidget, FWL_HLISTITEM hItem) { if (!hItem) - return -1; + return 0; return reinterpret_cast(hItem)->m_dwStates; } -- cgit v1.2.3