From 5fe7ae721a2e843007de69fcf76c252da942440f Mon Sep 17 00:00:00 2001 From: Wei Li Date: Wed, 4 May 2016 21:13:15 -0700 Subject: Properly fix the warnings ASSERT(statement) will not execute statement in release builds. So need to move statements outside ASSERT(). TBR=tsepez@chromium.org,dsinclair@chromium.org Review URL: https://codereview.chromium.org/1949613004 . --- xfa/fxfa/parser/xfa_object_imp.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp index 32da7f7a17..91497a50d0 100644 --- a/xfa/fxfa/parser/xfa_object_imp.cpp +++ b/xfa/fxfa/parser/xfa_object_imp.cpp @@ -4574,7 +4574,8 @@ CXFA_Node* CXFA_Node::GetChild(int32_t index, int32_t CXFA_Node::InsertChild(int32_t index, CXFA_Node* pNode) { ASSERT(!pNode->m_pNext); pNode->m_pParent = this; - ASSERT(m_pDocument->RemovePurgeNode(pNode)); + FX_BOOL ret = m_pDocument->RemovePurgeNode(pNode); + ASSERT(ret); if (m_pChild == NULL || index == 0) { if (index > 0) { @@ -4622,7 +4623,8 @@ FX_BOOL CXFA_Node::InsertChild(CXFA_Node* pNode, CXFA_Node* pBeforeNode) { ASSERT(false); return FALSE; } - ASSERT(m_pDocument->RemovePurgeNode(pNode)); + FX_BOOL ret = m_pDocument->RemovePurgeNode(pNode); + ASSERT(ret); int32_t nIndex = -1; pNode->m_pParent = this; -- cgit v1.2.3