From 60027a205953e95b230f289118448b55f12f9a94 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Thu, 15 Feb 2018 18:56:41 +0000 Subject: Actually enable -Wimplicit-fallthrough for pdfium. I forgot to do this in https://pdfium-review.googlesource.com/c/pdfium/+/26210 which made PDFium compile with the warning enabled. Bug: 807632 Change-Id: Id12e3df3073f3b9550d5bc9dfea0068088496f8a Reviewed-on: https://pdfium-review.googlesource.com/26910 Reviewed-by: dsinclair Reviewed-by: Tom Sepez Commit-Queue: Nico Weber --- BUILD.gn | 4 ---- 1 file changed, 4 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index bdadebd400..fd18f13953 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -71,10 +71,6 @@ config("pdfium_common_config") { # Assume UTF-8 by default to avoid code page dependencies. cflags += [ "/utf-8" ] } - if (is_clang) { - # TODO(thakis): Consider enabling this, https://crbug.com/807632 - cflags += [ "-Wno-implicit-fallthrough" ] - } } config("pdfium_core_config") { -- cgit v1.2.3