From 6058730c73c78db9ec710f3b4165526acdf19e9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20R=C3=B6ttsches?= Date: Fri, 21 Apr 2017 15:36:32 +0300 Subject: Fix Visual Studio build from GN generated files VS does not like to see <, > in the XML nodes of the build files. Work around this issue by replacing less-than and greater-than characters in the FreeType custom config include file path definitions with escaped quotes. BUG=pdfium:701 Change-Id: I879ade670158ccb4d435b65cde382c6e6b32e002 Reviewed-on: https://pdfium-review.googlesource.com/4330 Reviewed-by: Lei Zhang Reviewed-by: dsinclair Reviewed-by: Cary Clark Commit-Queue: Lei Zhang --- third_party/BUILD.gn | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn index c270a1063a..7730212c75 100644 --- a/third_party/BUILD.gn +++ b/third_party/BUILD.gn @@ -64,8 +64,11 @@ if (pdf_bundle_freetype) { "//third_party/freetype/src/include", ] defines = [ - "FT_CONFIG_MODULES_H=", - "FT_CONFIG_OPTIONS_H=", + # GN currently does not escape '<' and '>' when generating xml based + # Visual Studio project files. As a result, use quotes instead of pointy + # brackets in these defines. + "FT_CONFIG_MODULES_H=\"freetype-custom-config/ftmodule.h\"", + "FT_CONFIG_OPTIONS_H=\"freetype-custom-config/ftoption.h\"", ] } -- cgit v1.2.3