From 6287ebc38e5aafc256b6248caae710ea09d0ede4 Mon Sep 17 00:00:00 2001 From: Oliver Chang Date: Fri, 18 Dec 2015 14:27:56 -0800 Subject: Fix a memory leak in CPDF_DataAvail::CheckHintTables R=thestig@chromium.org, dml@google.com BUG=pdfium:327 Review URL: https://codereview.chromium.org/1536113002 . --- core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp index e098112ba1..97f17032b4 100644 --- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp +++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp @@ -3600,10 +3600,11 @@ FX_BOOL CPDF_DataAvail::CheckHintTables(IFX_DownloadHints* pHints) { m_syntaxParser.InitParser(m_pFileRead, m_dwHeaderOffset); nonstd::unique_ptr pHintTables( new CPDF_HintTables(this, pDict)); - CPDF_Stream* pHintStream = (CPDF_Stream*)ParseIndirectObjectAt(szHSStart, 0); - if (pHintStream && pHintStream->GetType() == PDFOBJ_STREAM && - pHintTables->LoadHintStream(pHintStream)) - m_pHintTables.reset(pHintTables.release()); + nonstd::unique_ptr> pHintStream( + ParseIndirectObjectAt(szHSStart, 0)); + CPDF_Stream* pStream = ToStream(pHintStream.get()); + if (pStream && pHintTables->LoadHintStream(pStream)) + m_pHintTables = nonstd::move(pHintTables); m_docStatus = PDF_DATAAVAIL_DONE; return TRUE; -- cgit v1.2.3