From 65be34f5356ac43b973d41839da9c84f82b9ca17 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 14 Sep 2018 20:58:36 +0000 Subject: Change two memcpys to iterator form of vector constructor. Because bytestring supports standard iterators. Change-Id: Iaa33d79dbbf07d660eee1dd95d9f5f15547fb57c Reviewed-on: https://pdfium-review.googlesource.com/42511 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- fpdfsdk/cpdfsdk_interform.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fpdfsdk/cpdfsdk_interform.cpp b/fpdfsdk/cpdfsdk_interform.cpp index 0e44268b39..d8f999ec72 100644 --- a/fpdfsdk/cpdfsdk_interform.cpp +++ b/fpdfsdk/cpdfsdk_interform.cpp @@ -500,12 +500,10 @@ bool CPDFSDK_InterForm::SubmitFields(const WideString& csDestination, bool bIncludeOrExclude, bool bUrlEncoded) { ByteString textBuf = ExportFieldsToFDFTextBuf(fields, bIncludeOrExclude); - size_t nBufSize = textBuf.GetLength(); - if (nBufSize == 0) + if (textBuf.IsEmpty()) return false; - std::vector buffer(nBufSize); - memcpy(buffer.data(), textBuf.c_str(), nBufSize); + std::vector buffer(textBuf.begin(), textBuf.end()); if (bUrlEncoded && !FDFToURLEncodedData(&buffer)) return false; @@ -539,8 +537,7 @@ bool CPDFSDK_InterForm::SubmitForm(const WideString& sDestination, if (fdfBuffer.IsEmpty()) return false; - std::vector buffer(fdfBuffer.GetLength()); - memcpy(buffer.data(), fdfBuffer.c_str(), fdfBuffer.GetLength()); + std::vector buffer(fdfBuffer.begin(), fdfBuffer.end()); if (bUrlEncoded && !FDFToURLEncodedData(&buffer)) return false; -- cgit v1.2.3