From 677329c9fa9f4f9e1a06f15e8d33d8a734cc5349 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Thu, 30 Mar 2017 17:58:40 +0000 Subject: Revert "Enable Wshift-negative-value in PDFium." This reverts commit 21362ee6370e6ef0f5a8275af5afde3f127887c9. Reason for revert: Breaks win_clang. Original change's description: > Enable Wshift-negative-value in PDFium. > > BUG=chromium:507717 > > Change-Id: If0030640497ce103de7713f8497570602950a2b6 > Reviewed-on: https://pdfium-review.googlesource.com/3270 > Commit-Queue: Nico Weber > Reviewed-by: Nico Weber > TBR=thestig@chromium.org,thakis@chromium.org,pdfium-reviews@googlegroups.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=chromium:507717 Change-Id: I4d482b6b7dade74373995f6d9cfdc6d1d66431a3 Reviewed-on: https://pdfium-review.googlesource.com/3410 Reviewed-by: Nico Weber Commit-Queue: dsinclair --- third_party/BUILD.gn | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn index a24e99e7f0..33a9fa2ebe 100644 --- a/third_party/BUILD.gn +++ b/third_party/BUILD.gn @@ -272,11 +272,21 @@ static_library("fx_lcms2") { } # This is only used for standalone builds. +config("jpeg_warnings") { + visibility = [ ":*" ] + if (is_clang) { + cflags = [ "-Wno-shift-negative-value" ] + } +} + static_library("jpeg") { configs -= [ "//build/config/compiler:chromium_code" ] configs += [ "//build/config/compiler:no_chromium_code", ":pdfium_third_party_config", + + # Must be after no_chromium_code for warning flags to be ordered correctly. + ":jpeg_warnings", ] sources = [ "libjpeg/cderror.h", -- cgit v1.2.3