From 6f34355e9d091fd4e031e9354fdfa778000b0d4a Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Wed, 16 Sep 2015 13:53:42 -0700 Subject: Make pdfium_embeddertests link in debug component builds. Target v8 has: 'direct_dependent_settings': { 'defines': [ 'V8_SHARED', 'USING_V8_SHARED', ], }, For this to work, targets using v8 headers have to depend on v8 directly, else the V8_EXPORT macro won't work. Add a direct dependency on v8. BUG=none TEST=do a debug component build of pdfium_embeddertests on Win, should work without linker errors R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1349843002 . --- BUILD.gn | 1 + pdfium.gyp | 1 + 2 files changed, 2 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 17276e0744..bba48180a9 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -776,6 +776,7 @@ test("pdfium_embeddertests") { deps = [ "//testing/gmock", "//testing/gtest", + "//v8", "//v8:v8_libplatform", ":pdfium", ] diff --git a/pdfium.gyp b/pdfium.gyp index 5c8799e9a5..12314d7e93 100644 --- a/pdfium.gyp +++ b/pdfium.gyp @@ -731,6 +731,7 @@ 'dependencies': [ '<(DEPTH)/testing/gmock.gyp:gmock', '<(DEPTH)/testing/gtest.gyp:gtest', + '<(DEPTH)/v8/tools/gyp/v8.gyp:v8', '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform', 'pdfium', ], -- cgit v1.2.3