From 6fc1bf199833d6cb409e8134fe5d6894e8323673 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 30 Jul 2015 15:53:59 -0700 Subject: Fix return check in CFX_FolderFontInfo::ScanFile() fread. If you want to check the number of bytes read, you need to change the order of arguments. TEST=testing/corpus/fx/mulobj/1/1_10_watermark.pdf.0.png R=thestig@chromium.org Review URL: https://codereview.chromium.org/1262453006 . --- core/src/fxge/ge/fx_ge_fontmap.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/fxge/ge/fx_ge_fontmap.cpp b/core/src/fxge/ge/fx_ge_fontmap.cpp index 14427a5e40..9bbebd9917 100644 --- a/core/src/fxge/ge/fx_ge_fontmap.cpp +++ b/core/src/fxge/ge/fx_ge_fontmap.cpp @@ -1367,7 +1367,7 @@ void CFX_FolderFontInfo::ScanFile(CFX_ByteString& path) } FX_DWORD face_bytes = nFaces * 4; uint8_t* offsets = FX_Alloc(uint8_t, face_bytes); - readCnt = FXSYS_fread(offsets, face_bytes, 1, pFile); + readCnt = FXSYS_fread(offsets, 1, face_bytes, pFile); if (readCnt != face_bytes) { FX_Free(offsets); FXSYS_fclose(pFile); -- cgit v1.2.3