From 719a7a71d4cf1b714ad7f76e5f9ca28cfd5b74d3 Mon Sep 17 00:00:00 2001 From: dsinclair Date: Mon, 16 May 2016 08:11:18 -0700 Subject: Readme update to make need for pdfium_is_standalone clear. Add a note about the need for pdfium_is_standalone and fix some spelling mistakes along the way. Review-Url: https://codereview.chromium.org/1979243002 --- README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index fb1498f64d..dbbed5be62 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ if you need to use the system toolchain. See Get the chromium depot tools via the instructions at http://www.chromium.org/developers/how-tos/install-depot-tools (this provides -the gclient utilty needed below). +the gclient utility needed below). Also install Python, Subversion, and Git and make sure they're in your path. @@ -76,7 +76,7 @@ gn gen If you want to set to `out/Debug` or `out/Release` you'll need to export `GYP_PDFIUM_NO_ACTION=1` to stop `gclient sync` from executing GYP -and overwritting your build files. +and overwriting your build files. ### Selecting build configuration @@ -85,7 +85,7 @@ or without XFA forms support. Both of these features are enabled by default. Also note that the XFA feature requires JavaScript. Configuration is done by executing `gn args ` to configure the build. -This will lauch an editor in which you can set the following arguments. +This will launch an editor in which you can set the following arguments. ``` use_goma = true # Googlers only. @@ -100,6 +100,9 @@ pdf_is_standalone = true # Set for a non-embedded build. clang_use_chrome_plugins = false # Currently must be false. ``` +Note, you must set `pdf_is_standalone = true` if you want the sample +applications like `pdfium_test` to build. + When complete the arguments will be stored in `/args.gn`. ## Building the code -- cgit v1.2.3