From 800265a4e3203cdb284acce4b3a051f9ce795b01 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 4 Mar 2016 14:49:36 -0800 Subject: Turn on -Werror for standalone builds. This required suppressing the non-virtual-dtor warning, since ICU isn't clean. Getting -Werror in exchange for that seems worthwhile. Chromium's builds are controlled by its own files, which already -Werror. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1765893003 . --- build/standalone.gypi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build/standalone.gypi b/build/standalone.gypi index f00af23aeb..1e7c0c0dc0 100644 --- a/build/standalone.gypi +++ b/build/standalone.gypi @@ -171,6 +171,7 @@ }, 'cflags': [ '-Wall', + '-Werror', '-W', '-Wno-missing-field-initializers', # Code might someday be made clean for -Wsign-compare, but for now @@ -183,7 +184,8 @@ ], 'cflags_cc': [ '-std=c++11', - '-Wnon-virtual-dtor', + # Add back when ICU is clean + # '-Wnon-virtual-dtor', '-fno-rtti', ], 'ldflags': [ -- cgit v1.2.3