From 860a3eb0f3c18853f95df5a70dc50a95a29aafb1 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 23 Sep 2015 11:10:54 -0700 Subject: Merge to M45: Fix JS_GetArrayElement to not return an empty handle on success BUG=chromium:528376 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1337433002 . (cherry picked from commit 0d0935d3d6603dd7d851b1d5828635230f4c43ca) Review URL: https://codereview.chromium.org/1364833002 . --- fpdfsdk/src/jsapi/fxjs_v8.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp index 7adfc2696d..af0000343a 100644 --- a/fpdfsdk/src/jsapi/fxjs_v8.cpp +++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp @@ -635,7 +635,7 @@ v8::Local JS_GetArrayElement(IJS_Runtime* pJSRuntime, v8::Local(); v8::Local val; - if (pArray->Get(pJSRuntime->GetCurrentContext(), index).ToLocal(&val)) return v8::Local(); + if (!pArray->Get(pJSRuntime->GetCurrentContext(), index).ToLocal(&val)) return v8::Local(); return val; } -- cgit v1.2.3