From 882ed81dec7afc5bc106f965af34f1e59407fd95 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Thu, 13 Sep 2018 17:45:05 +0000 Subject: Make things more const-y Follow up to https://pdfium-review.googlesource.com/c/pdfium/+/42350 to use const more in the changed code. BUG=chromium:881678 Change-Id: I7a88862952c9ba25ffa89c2827e1de322f3b5c33 Reviewed-on: https://pdfium-review.googlesource.com/42370 Commit-Queue: Ryan Harrison Reviewed-by: Lei Zhang Reviewed-by: Henrique Nakashima --- core/fpdfapi/font/cpdf_cmap.h | 2 +- core/fpdfapi/font/cpdf_cmapparser.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/fpdfapi/font/cpdf_cmap.h b/core/fpdfapi/font/cpdf_cmap.h index 68ad26cfa3..5526293685 100644 --- a/core/fpdfapi/font/cpdf_cmap.h +++ b/core/fpdfapi/font/cpdf_cmap.h @@ -66,7 +66,7 @@ class CPDF_CMap final : public Retainable { void SetVertical(bool vert) { m_bVertical = vert; } void SetCodingScheme(CodingScheme scheme) { m_CodingScheme = scheme; } - const std::vector& GetMixedFourByteLeadingRanges() { + const std::vector& GetMixedFourByteLeadingRanges() const { return m_MixedFourByteLeadingRanges; } void AppendMixedFourByteLeadingRanges(const CodeRange& range) { diff --git a/core/fpdfapi/font/cpdf_cmapparser.cpp b/core/fpdfapi/font/cpdf_cmapparser.cpp index 5bfe17b34f..fca1c92af9 100644 --- a/core/fpdfapi/font/cpdf_cmapparser.cpp +++ b/core/fpdfapi/font/cpdf_cmapparser.cpp @@ -109,7 +109,7 @@ void CPDF_CMapParser::ParseWord(const ByteStringView& word) { m_Status = 0; } else if (m_Status == 7) { if (word == "endcodespacerange") { - auto code_ranges = m_pCMap->GetMixedFourByteLeadingRanges(); + const auto& code_ranges = m_pCMap->GetMixedFourByteLeadingRanges(); size_t nSegs = code_ranges.size(); if (nSegs == 1) { m_pCMap->SetCodingScheme((code_ranges[0].m_CharSize == 2) @@ -117,7 +117,7 @@ void CPDF_CMapParser::ParseWord(const ByteStringView& word) { : CPDF_CMap::OneByte); } else if (nSegs > 1) { m_pCMap->SetCodingScheme(CPDF_CMap::MixedFourBytes); - for (auto range : m_PendingRanges) + for (const auto& range : m_PendingRanges) m_pCMap->AppendMixedFourByteLeadingRanges(range); m_PendingRanges.clear(); } -- cgit v1.2.3