From 9a25eded6f4afe3f4815a00b34b31d3a0fbadb69 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Thu, 22 Jun 2017 00:05:12 -0700 Subject: Clean up includes in testing/test_support.h Change-Id: Id558c36d10501ce488717045bbf00bfed32e4b92 Reviewed-on: https://pdfium-review.googlesource.com/6870 Commit-Queue: dsinclair Reviewed-by: dsinclair --- samples/pdfium_test.cc | 1 + testing/test_support.cpp | 4 ++-- testing/test_support.h | 13 +++++++------ 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc index 14aa6c187d..a53edb77d3 100644 --- a/samples/pdfium_test.cc +++ b/samples/pdfium_test.cc @@ -7,6 +7,7 @@ #include #include +#include #include #include #include diff --git a/testing/test_support.cpp b/testing/test_support.cpp index 608e4ae75b..681a7baca3 100644 --- a/testing/test_support.cpp +++ b/testing/test_support.cpp @@ -7,13 +7,13 @@ #include #include -#include - +#include "core/fdrm/crypto/fx_crypt.h" #include "core/fxcrt/fx_memory.h" #include "testing/utils/path_service.h" #ifdef PDF_ENABLE_V8 #include "v8/include/libplatform/libplatform.h" +#include "v8/include/v8.h" #endif namespace { diff --git a/testing/test_support.h b/testing/test_support.h index 7795be4214..146582251f 100644 --- a/testing/test_support.h +++ b/testing/test_support.h @@ -6,18 +6,13 @@ #define TESTING_TEST_SUPPORT_H_ #include + #include #include #include -#include "core/fdrm/crypto/fx_crypt.h" #include "public/fpdf_save.h" #include "public/fpdfview.h" -#include "testing/gtest/include/gtest/gtest.h" - -#ifdef PDF_ENABLE_V8 -#include "v8/include/v8.h" -#endif // PDF_ENABLE_V8 namespace pdfium { @@ -81,7 +76,13 @@ std::string CryptToBase16(const uint8_t* digest); std::string GenerateMD5Base16(const uint8_t* data, uint32_t size); #ifdef PDF_ENABLE_V8 +namespace v8 { +class Platform; +} #ifdef V8_USE_EXTERNAL_STARTUP_DATA +namespace v8 { +class StartupData; +} bool InitializeV8ForPDFium(const std::string& exe_path, const std::string& bin_dir, v8::StartupData* natives_blob, -- cgit v1.2.3