From 9bad23500e4aa1f167ae03b469c06b2f317e873a Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Thu, 28 Jun 2018 13:29:33 +0000 Subject: Replace DCHECKs with ASSERTs. Change-Id: I0f2bf1cb44b4cba872a719f0a75d8776f413812c Reviewed-on: https://pdfium-review.googlesource.com/36250 Commit-Queue: dsinclair Reviewed-by: dsinclair --- core/fpdfapi/parser/cpdf_document.cpp | 4 ++-- core/fpdfapi/parser/cpdf_object_stream.cpp | 2 +- fxjs/cjs_global.cpp | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/core/fpdfapi/parser/cpdf_document.cpp b/core/fpdfapi/parser/cpdf_document.cpp index 91c6b9c6f9..4f699139a3 100644 --- a/core/fpdfapi/parser/cpdf_document.cpp +++ b/core/fpdfapi/parser/cpdf_document.cpp @@ -248,7 +248,7 @@ void CPDF_Document::LoadPages() { } m_PageList.resize(linearized_header->GetPageCount()); - DCHECK(linearized_header->GetFirstPageNo() < m_PageList.size()); + ASSERT(linearized_header->GetFirstPageNo() < m_PageList.size()); m_PageList[linearized_header->GetFirstPageNo()] = linearized_header->GetFirstPageObjNum(); } @@ -326,7 +326,7 @@ void CPDF_Document::ResetTraversal() { } void CPDF_Document::SetParser(std::unique_ptr pParser) { - DCHECK(!m_pParser); + ASSERT(!m_pParser); m_pParser = std::move(pParser); } diff --git a/core/fpdfapi/parser/cpdf_object_stream.cpp b/core/fpdfapi/parser/cpdf_object_stream.cpp index 779fbffd83..2d0bd993aa 100644 --- a/core/fpdfapi/parser/cpdf_object_stream.cpp +++ b/core/fpdfapi/parser/cpdf_object_stream.cpp @@ -60,7 +60,7 @@ std::unique_ptr CPDF_ObjectStream::Create( CPDF_ObjectStream::CPDF_ObjectStream(const CPDF_Stream* obj_stream) : obj_num_(obj_stream->GetObjNum()), first_object_offset_(obj_stream->GetDict()->GetIntegerFor("First")) { - DCHECK(IsObjectsStreamObject(obj_stream)); + ASSERT(IsObjectsStreamObject(obj_stream)); if (const auto* extends_ref = ToReference(obj_stream->GetDict()->GetObjectFor("Extends"))) { extends_obj_num_ = extends_ref->GetRefObjNum(); diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp index e9b2a4b8f0..6396aa7705 100644 --- a/fxjs/cjs_global.cpp +++ b/fxjs/cjs_global.cpp @@ -143,7 +143,7 @@ void CJS_Global::setPersistent_static( void CJS_Global::queryprop_static( v8::Local property, const v8::PropertyCallbackInfo& info) { - DCHECK(property->IsString()); + ASSERT(property->IsString()); JSSpecialPropQuery( "global", v8::Local::New(info.GetIsolate(), property->ToString()), @@ -154,7 +154,7 @@ void CJS_Global::queryprop_static( void CJS_Global::getprop_static( v8::Local property, const v8::PropertyCallbackInfo& info) { - DCHECK(property->IsString()); + ASSERT(property->IsString()); JSSpecialPropGet( "global", v8::Local::New(info.GetIsolate(), property->ToString()), @@ -166,7 +166,7 @@ void CJS_Global::putprop_static( v8::Local property, v8::Local value, const v8::PropertyCallbackInfo& info) { - DCHECK(property->IsString()); + ASSERT(property->IsString()); JSSpecialPropPut( "global", v8::Local::New(info.GetIsolate(), property->ToString()), @@ -177,7 +177,7 @@ void CJS_Global::putprop_static( void CJS_Global::delprop_static( v8::Local property, const v8::PropertyCallbackInfo& info) { - DCHECK(property->IsString()); + ASSERT(property->IsString()); JSSpecialPropDel( "global", v8::Local::New(info.GetIsolate(), property->ToString()), -- cgit v1.2.3