From a7c9c0127f47b9dd9768ca4c256a269ab1c07a86 Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Wed, 24 May 2017 22:10:03 -0400 Subject: Enable remaining boolean FM2JSContext tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This CL updates the return type of the remaining boolean tests to be Integer and enables the tests. Change-Id: Ie2856ad31d17ffb496f33e6969912d0aae9678c5 Reviewed-on: https://pdfium-review.googlesource.com/5895 Reviewed-by: Nicolás Peña Commit-Queue: dsinclair --- xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp b/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp index d0d657ee50..a61203cc0b 100644 --- a/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp +++ b/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp @@ -829,7 +829,7 @@ TEST_F(FM2JSContextEmbedderTest, Exists) { EXPECT_FALSE(value->ToBoolean()); } -TEST_F(FM2JSContextEmbedderTest, DISABLED_HasValue) { +TEST_F(FM2JSContextEmbedderTest, HasValue) { ASSERT_TRUE(OpenDocument("simple_xfa.pdf")); struct { @@ -841,13 +841,13 @@ TEST_F(FM2JSContextEmbedderTest, DISABLED_HasValue) { EXPECT_TRUE(Execute(tests[i].program)); CFXJSE_Value* value = GetValue(); - EXPECT_TRUE(value->IsBoolean()) << "Program: " << tests[i].program; + EXPECT_TRUE(value->IsInteger()) << "Program: " << tests[i].program; EXPECT_EQ(tests[i].result, value->ToBoolean()) << "Program: " << tests[i].program; } } -TEST_F(FM2JSContextEmbedderTest, DISABLED_Oneof) { +TEST_F(FM2JSContextEmbedderTest, Oneof) { ASSERT_TRUE(OpenDocument("simple_xfa.pdf")); struct { @@ -863,13 +863,13 @@ TEST_F(FM2JSContextEmbedderTest, DISABLED_Oneof) { EXPECT_TRUE(Execute(tests[i].program)); CFXJSE_Value* value = GetValue(); - EXPECT_TRUE(value->IsBoolean()) << "Program: " << tests[i].program; + EXPECT_TRUE(value->IsInteger()) << "Program: " << tests[i].program; EXPECT_EQ(tests[i].result, value->ToBoolean()) << "Program: " << tests[i].program; } } -TEST_F(FM2JSContextEmbedderTest, DISABLED_Within) { +TEST_F(FM2JSContextEmbedderTest, Within) { ASSERT_TRUE(OpenDocument("simple_xfa.pdf")); struct { @@ -883,7 +883,7 @@ TEST_F(FM2JSContextEmbedderTest, DISABLED_Within) { EXPECT_TRUE(Execute(tests[i].program)); CFXJSE_Value* value = GetValue(); - EXPECT_TRUE(value->IsBoolean()) << "Program: " << tests[i].program; + EXPECT_TRUE(value->IsInteger()) << "Program: " << tests[i].program; EXPECT_EQ(tests[i].result, value->ToBoolean()) << "Program: " << tests[i].program; } -- cgit v1.2.3