From b372dc6b20fca803aef86583551982fb9178011f Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 11 Jun 2018 17:33:52 +0000 Subject: Remove explicit calls to x->operator[] Because its a code smell of a sort. Change-Id: Id1c1b124f539e31a929701fb9486da9d396d3563 Reviewed-on: https://pdfium-review.googlesource.com/34695 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- core/fpdftext/cpdf_textpagefind.cpp | 2 +- core/fxcodec/gif/cfx_lzwdecompressor_unittest.cpp | 4 ++-- fxbarcode/common/BC_CommonByteArray.cpp | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/core/fpdftext/cpdf_textpagefind.cpp b/core/fpdftext/cpdf_textpagefind.cpp index 52fdb4aa38..62bc3cb87c 100644 --- a/core/fpdftext/cpdf_textpagefind.cpp +++ b/core/fpdftext/cpdf_textpagefind.cpp @@ -292,7 +292,7 @@ void CPDF_TextPageFind::ExtractFindWhat(const WideString& findwhat) { size_t pos = 0; while (pos < word->GetLength()) { WideString curStr = word->Mid(pos, 1); - wchar_t curChar = word->operator[](pos); + wchar_t curChar = (*word)[pos]; if (IsIgnoreSpaceCharacter(curChar)) { if (pos > 0 && curChar == 0x2019) { pos++; diff --git a/core/fxcodec/gif/cfx_lzwdecompressor_unittest.cpp b/core/fxcodec/gif/cfx_lzwdecompressor_unittest.cpp index 551bc1e23e..0a2c359a85 100644 --- a/core/fxcodec/gif/cfx_lzwdecompressor_unittest.cpp +++ b/core/fxcodec/gif/cfx_lzwdecompressor_unittest.cpp @@ -33,7 +33,7 @@ TEST(CFX_LZWDecompressor, ExtractData) { EXPECT_EQ(10u, *(decompressor->DecompressedNextForTest())); for (size_t i = 0; i < *(decompressor->DecompressedNextForTest()); ++i) - EXPECT_EQ(i, decompressed->operator[](i)); + EXPECT_EQ(i, (*decompressed)[i]); } // Check that less than decompressed size only gets the expected number @@ -53,7 +53,7 @@ TEST(CFX_LZWDecompressor, ExtractData) { EXPECT_EQ(5u, *(decompressor->DecompressedNextForTest())); for (i = 0; i < *(decompressor->DecompressedNextForTest()); ++i) - EXPECT_EQ(i, decompressed->operator[](i)); + EXPECT_EQ(i, (*decompressed)[i]); } // Check that greater than decompressed size depletes the decompressor diff --git a/fxbarcode/common/BC_CommonByteArray.cpp b/fxbarcode/common/BC_CommonByteArray.cpp index d66568c596..bb4fbf8af5 100644 --- a/fxbarcode/common/BC_CommonByteArray.cpp +++ b/fxbarcode/common/BC_CommonByteArray.cpp @@ -95,8 +95,7 @@ void CBC_CommonByteArray::Set(std::vector* source, m_bytes = FX_Alloc(uint8_t, count); m_size = count; int32_t i; - for (i = 0; i < count; i++) { - m_bytes[i] = source->operator[](i + offset); - } + for (i = 0; i < count; i++) + m_bytes[i] = (*source)[i + offset]; m_index = m_size; } -- cgit v1.2.3