From bb8935e9def5ad865be613eebea597a77fc7c547 Mon Sep 17 00:00:00 2001 From: tsepez Date: Tue, 13 Sep 2016 06:33:15 -0700 Subject: Get rid of memcmp in CFieldTree::Lookup() Wide strings compare just fine on their own. Review-Url: https://codereview.chromium.org/2331233002 --- core/fpdfdoc/cpdf_interform.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/core/fpdfdoc/cpdf_interform.cpp b/core/fpdfdoc/cpdf_interform.cpp index d567e09e82..0ebf4460cf 100644 --- a/core/fpdfdoc/cpdf_interform.cpp +++ b/core/fpdfdoc/cpdf_interform.cpp @@ -634,11 +634,8 @@ CFieldTree::Node* CFieldTree::Lookup(Node* pParent, for (int i = 0; i < pParent->children.GetSize(); i++) { Node* pNode = pParent->children[i]; - if (pNode->short_name.GetLength() == short_name.GetLength() && - FXSYS_memcmp(pNode->short_name.c_str(), short_name.c_str(), - short_name.GetLength() * sizeof(FX_WCHAR)) == 0) { + if (pNode->short_name == short_name) return pNode; - } } return nullptr; } -- cgit v1.2.3