From bfc5f6011dd402a1fc07a522c3f25ab405f3e3ea Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Thu, 11 Oct 2018 19:28:08 +0000 Subject: Add check_targets list to .gn. Start trying to pass "gn check". Change-Id: Iec694d8abf558f3e1ca477dd3934020088e43cb5 Reviewed-on: https://pdfium-review.googlesource.com/c/43895 Reviewed-by: Henrique Nakashima Commit-Queue: Lei Zhang --- .gn | 13 +++++++++++++ samples/BUILD.gn | 6 ++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/.gn b/.gn index 41187fd2f5..59db446ec0 100644 --- a/.gn +++ b/.gn @@ -15,3 +15,16 @@ default_args = { # PDFium does not want to switch to C++14 yet. use_cxx11 = true } + +check_targets = [ + "//samples/*", + + # TODO(thestig): Work on these. + #"//core/*", # Need to split off. + #"//fpdfsdk/*", # Need to split off. + #"//fxbarcode/*", # Need to split off. + #"//fxjs/*", # Need to split off. + #"//testing/*", + #"//testing/fuzzers/*", + #"//xfa/*", # Need to split off. +] diff --git a/samples/BUILD.gn b/samples/BUILD.gn index 30cc8ef6e9..909de2eae0 100644 --- a/samples/BUILD.gn +++ b/samples/BUILD.gn @@ -58,10 +58,12 @@ executable("pdfium_test") { configs += [ ":pdfium_samples_config" ] if (pdf_enable_v8) { - deps += [ "//v8:v8_libplatform" ] + deps += [ + "//v8:v8_headers", + "//v8:v8_libplatform", + ] include_dirs = [ "//v8", - "//v8/include", ] configs += [ "//v8:external_startup_data" ] } -- cgit v1.2.3