From d0cfb8cc152321f552a9d7c9754e9f05e3352e75 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Sat, 25 Feb 2017 00:33:40 -0800 Subject: M57: Use container with stable iterator for m_Icons. The container may grow while it is being traversed in JS. BUG=691371 Change-Id: I73ee536458697267c69e6c3ada96e28546d11a4e Reviewed-on: https://pdfium-review.googlesource.com/2690 Reviewed-by: dsinclair Commit-Queue: Tom Sepez (cherry picked from commit 9e41d0461d175410f6ea7573e729dc1ae14e846d) Change-Id: I458e3e581616f10b157d118c60730df8324992d2 Reviewed-on: https://pdfium-review.googlesource.com/2842 Reviewed-by: dsinclair Reviewed-by: Tom Sepez --- fpdfsdk/javascript/Document.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpdfsdk/javascript/Document.h b/fpdfsdk/javascript/Document.h index 227c4284bb..7786c77881 100644 --- a/fpdfsdk/javascript/Document.h +++ b/fpdfsdk/javascript/Document.h @@ -288,7 +288,7 @@ class Document : public CJS_EmbedObj { CPDFSDK_FormFillEnvironment::ObservedPtr m_pFormFillEnv; CFX_WideString m_cwBaseURL; std::list> m_DelayData; - std::vector> m_Icons; + std::list> m_Icons; // For iterator stability. bool m_bDelay; }; -- cgit v1.2.3