From d27998f6526272a5b8732106aa9b75f724434aca Mon Sep 17 00:00:00 2001 From: Bruce Dawson Date: Thu, 10 Aug 2017 16:07:07 -0700 Subject: Fix component builds for FreeType changes FreeType has changed so it doesn't define ft_adobe_glyph_list once for every translation unit, which avoids wasting space in the data segment with duplicates. However Chromium component builds were depending on this behavior. This fixes component builds while avoiding duplicate arrays in non-component builds. This change makes no difference to pdfium at the moment but will probably be needed when it gains support for component builds. Change-Id: Ieed7c711bdbd3fa6eef19da60e906667dab8fb1b Reviewed-on: https://pdfium-review.googlesource.com/10670 Commit-Queue: Bruce Dawson Reviewed-by: Lei Zhang --- BUILD.gn | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 9dc2362aa6..cd2b0b05db 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -1070,6 +1070,11 @@ static_library("fxge") { ] defines = [ "DEFINE_PS_TABLES" ] + if (is_component_build) { + # ft_adobe_glyph_list is not exported from the Freetype shared library so we + # need it defined in component builds. + defines += [ "DEFINE_PS_TABLES_DATA" ] + } if (pdf_enable_xfa) { sources += [ -- cgit v1.2.3