From d6d9dc6b9a45368abdf43477592ee9f6cdb6102e Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 28 Sep 2015 10:20:16 -0700 Subject: Fix test diff caused by v8 version update Also changes DEPS to specify a specific v8 version, this will require us to manually update this version from time to time, but also solves a longstanding problem where going back to an older version (say for bisecting) wouldn't always work. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1372963003 . --- DEPS | 2 +- testing/resources/javascript/app_props_expected.txt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DEPS b/DEPS index ee9df7e861..d47820b42c 100644 --- a/DEPS +++ b/DEPS @@ -17,7 +17,7 @@ deps = { "https://chromium.googlesource.com/external/googletest.git@8245545b6dc9c4703e6496d1efd19e975ad2b038", "v8": - "https://chromium.googlesource.com/v8/v8.git", + "https://chromium.googlesource.com/v8/v8.git@4d03c3aabad6517ff058124bb799ca6a4156e570", "v8/third_party/icu": "https://chromium.googlesource.com/chromium/deps/icu46", diff --git a/testing/resources/javascript/app_props_expected.txt b/testing/resources/javascript/app_props_expected.txt index 6e78ba510b..a17e0f82b5 100644 --- a/testing/resources/javascript/app_props_expected.txt +++ b/testing/resources/javascript/app_props_expected.txt @@ -1,5 +1,5 @@ Alert: *** Getting properties *** -Alert: app.activeDocs is object [object Object] +Alert: app.activeDocs is object [object global] Alert: app.calculate is boolean true Alert: app.formsVersion is number 7 Alert: ERROR: app.fs: @@ -25,7 +25,7 @@ Alert: ERROR: app.viewerType: Alert: ERROR: app.viewerVariation: Alert: ERROR: app.viewerVersion: Alert: *** Getting properties *** -Alert: app.activeDocs is object [object Object] +Alert: app.activeDocs is object [object global] Alert: app.calculate is boolean true Alert: app.formsVersion is number 7 Alert: ERROR: app.fs: -- cgit v1.2.3