From e0f1310795f1cf886b9b2a134b28ace9e8fc25ba Mon Sep 17 00:00:00 2001 From: Jane Date: Tue, 23 May 2017 15:11:45 -0400 Subject: Minor updates to README Bug: Change-Id: Ibfaa5f528834fb21c77684b9f4921f17ce4b5789 Reviewed-on: https://pdfium-review.googlesource.com/5811 Commit-Queue: Jane Liu Reviewed-by: dsinclair --- README.md | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index c1b57c9f56..5d7f47fea5 100644 --- a/README.md +++ b/README.md @@ -58,6 +58,12 @@ gclient sync cd pdfium ``` +Additional build dependencies need to be installed by running: + +``` +./build/install-build-deps.sh +``` + ## Generate the build files We use GN to generate the build files and @@ -76,7 +82,7 @@ This will launch an editor in which you can set the following arguments. A typical `` name is `out/Debug`. ``` -use_goma = true # Googlers only. +use_goma = true # Googlers only. Make sure goma is installed and running first. is_debug = true # Enable debugging features. pdf_use_skia = false # Set true to enable experimental skia backend. @@ -154,7 +160,10 @@ and add the "Cr-Internals-Plugins-PDF" label. For contributing code, we will follow [Chromium's process](http://dev.chromium.org/developers/contributing-code) -as much as possible. The main exceptions is: +as much as possible. The main exceptions are: 1. Code has to conform to the existing style and not Chromium/Google style. +2. PDFium uses a different tool for code reviews, and credentials for +the tool need to be generated before uploading a CL. + -- cgit v1.2.3