From e14df7d86c641a42dcea5fa0eedfa16aa49fcb92 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 7 Mar 2017 16:23:37 -0500 Subject: Re-enable tests now that leak is fixed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The fixes to RTFBreak to convert to a vector have fixed the memory leak in these test files. Re-enable for asan and remove the asan hack from the suppressor. Change-Id: Id229d61101fdd2538b9bbc38b9364d694623da40 Reviewed-on: https://pdfium-review.googlesource.com/2937 Reviewed-by: Tom Sepez Reviewed-by: Nicolás Peña Commit-Queue: dsinclair --- testing/SUPPRESSIONS | 12 ------------ testing/tools/suppressor.py | 3 --- 2 files changed, 15 deletions(-) diff --git a/testing/SUPPRESSIONS b/testing/SUPPRESSIONS index 447c9fa529..fd228f1b17 100644 --- a/testing/SUPPRESSIONS +++ b/testing/SUPPRESSIONS @@ -487,18 +487,6 @@ zh_shared_document.pdf mac * * bug_679643.in * * noxfa bug_679642.in * * noxfa -### TODO(dsinclair): These need to be fixed .... -Test_DateField_locale_en_CA.pdf asan * * -Test_DateField_locale_en_GB.pdf asan * * -Test_DateField_locale_en_US.pdf asan * * -Test_DateField_locale_fr_CA.pdf asan * * -Test_DateField_locale_fr_FR.pdf asan * * -Test_DateField_locale_nl_NL.pdf asan * * -Test_DateField_locale_zh_CN.pdf asan * * -Test_DateField_locale_zh_HK.pdf asan * * -Test_PasswordField.pdf asan * * -format_custom_format.pdf asan * * - # # xfa_specific # diff --git a/testing/tools/suppressor.py b/testing/tools/suppressor.py index 86d2668adb..3b2872df95 100755 --- a/testing/tools/suppressor.py +++ b/testing/tools/suppressor.py @@ -12,7 +12,6 @@ class Suppressor: feature_vector = feature_string.strip().split(",") self.has_v8 = "V8" in feature_vector self.has_xfa = "XFA" in feature_vector - self.is_asan = "ASAN" in feature_vector v8_option = "v8" if self.has_v8 else "nov8" xfa_option = "xfa" if self.has_xfa else "noxfa" @@ -33,8 +32,6 @@ class Suppressor: os_column = item[1].split(","); js_column = item[2].split(","); xfa_column = item[3].split(","); - if self.is_asan and 'asan' in os_column: - return True return (('*' in os_column or os in os_column) and ('*' in js_column or js in js_column) and ('*' in xfa_column or xfa in xfa_column)) -- cgit v1.2.3