From e40764862208b8cb76f507c489b01e3795fd93bd Mon Sep 17 00:00:00 2001
From: Wei Li <weili@chromium.org>
Date: Tue, 15 Mar 2016 10:58:40 -0700
Subject: Modify xfa code to avoid c4800 warnings

BUG=pdfium:29
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1800793002 .
---
 core/fxge/ge/fx_ge_font.cpp            |  2 +-
 fpdfsdk/fpdfxfa/fpdfxfa_util.cpp       |  8 ++++----
 fpdfsdk/fsdk_baseform.cpp              | 16 ++++++++--------
 fpdfsdk/include/fpdfxfa/fpdfxfa_util.h | 11 +++++------
 4 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/core/fxge/ge/fx_ge_font.cpp b/core/fxge/ge/fx_ge_font.cpp
index 14783085ac..67b968b44d 100644
--- a/core/fxge/ge/fx_ge_font.cpp
+++ b/core/fxge/ge/fx_ge_font.cpp
@@ -488,7 +488,7 @@ FX_DWORD CFX_UnicodeEncodingEx::GlyphFromCharCode(FX_DWORD charcode) {
   int nmaps = FXFT_Get_Face_CharmapCount(face);
   int m = 0;
   while (m < nmaps) {
-    int nEncodingID =
+    FX_DWORD nEncodingID =
         FXFT_Get_Charmap_Encoding(FXFT_Get_Face_Charmaps(face)[m++]);
     if (m_nEncodingID == nEncodingID) {
       continue;
diff --git a/fpdfsdk/fpdfxfa/fpdfxfa_util.cpp b/fpdfsdk/fpdfxfa/fpdfxfa_util.cpp
index 7814d8bd8a..7cabe0fb80 100644
--- a/fpdfsdk/fpdfxfa/fpdfxfa_util.cpp
+++ b/fpdfsdk/fpdfxfa/fpdfxfa_util.cpp
@@ -20,10 +20,10 @@ FWL_ERR CXFA_FWLAdapterTimerMgr::Start(IFWL_Timer* pTimer,
   if (!m_pEnv)
     return FWL_ERR_Indefinite;
 
-  uint32_t uIDEvent = m_pEnv->FFI_SetTimer(dwElapse, TimerProc);
+  int32_t id_event = m_pEnv->FFI_SetTimer(dwElapse, TimerProc);
   if (!s_TimerArray)
     s_TimerArray = new std::vector<CFWL_TimerInfo*>;
-  s_TimerArray->push_back(new CFWL_TimerInfo(uIDEvent, pTimer));
+  s_TimerArray->push_back(new CFWL_TimerInfo(id_event, pTimer));
   hTimer = reinterpret_cast<FWL_HTIMER>(s_TimerArray->back());
   return FWL_ERR_Succeeded;
 }
@@ -33,7 +33,7 @@ FWL_ERR CXFA_FWLAdapterTimerMgr::Stop(FWL_HTIMER hTimer) {
     return FWL_ERR_Indefinite;
 
   CFWL_TimerInfo* pInfo = reinterpret_cast<CFWL_TimerInfo*>(hTimer);
-  m_pEnv->FFI_KillTimer(pInfo->uIDEvent);
+  m_pEnv->FFI_KillTimer(pInfo->idEvent);
   if (s_TimerArray) {
     auto it = std::find(s_TimerArray->begin(), s_TimerArray->end(), pInfo);
     if (it != s_TimerArray->end()) {
@@ -50,7 +50,7 @@ void CXFA_FWLAdapterTimerMgr::TimerProc(int32_t idEvent) {
     return;
 
   for (CFWL_TimerInfo* pInfo : *s_TimerArray) {
-    if (pInfo->uIDEvent == idEvent) {
+    if (pInfo->idEvent == idEvent) {
       pInfo->pTimer->Run(reinterpret_cast<FWL_HTIMER>(pInfo));
       break;
     }
diff --git a/fpdfsdk/fsdk_baseform.cpp b/fpdfsdk/fsdk_baseform.cpp
index 141e1f5f82..6a01813494 100644
--- a/fpdfsdk/fsdk_baseform.cpp
+++ b/fpdfsdk/fsdk_baseform.cpp
@@ -350,19 +350,19 @@ void CPDFSDK_Widget::SynchronizeXFAValue(IXFA_DocView* pXFADocView,
       case FIELDTYPE_CHECKBOX: {
         if (CXFA_WidgetAcc* pWidgetAcc =
                 pXFAWidgetHandler->GetDataAcc(hWidget)) {
-          FX_BOOL bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On;
-
-          pFormField->CheckControl(pFormField->GetControlIndex(pFormControl),
-                                   bChecked, TRUE);
+          pFormField->CheckControl(
+              pFormField->GetControlIndex(pFormControl),
+              pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On, true);
         }
       } break;
       case FIELDTYPE_RADIOBUTTON: {
+        // TODO(weili): Check whether we need to handle checkbox and radio
+        // button differently, otherwise, merge these two cases.
         if (CXFA_WidgetAcc* pWidgetAcc =
                 pXFAWidgetHandler->GetDataAcc(hWidget)) {
-          FX_BOOL bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On;
-
-          pFormField->CheckControl(pFormField->GetControlIndex(pFormControl),
-                                   bChecked, TRUE);
+          pFormField->CheckControl(
+              pFormField->GetControlIndex(pFormControl),
+              pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On, true);
         }
       } break;
       case FIELDTYPE_TEXTFIELD: {
diff --git a/fpdfsdk/include/fpdfxfa/fpdfxfa_util.h b/fpdfsdk/include/fpdfxfa/fpdfxfa_util.h
index af69812471..545d910206 100644
--- a/fpdfsdk/include/fpdfxfa/fpdfxfa_util.h
+++ b/fpdfsdk/include/fpdfxfa/fpdfxfa_util.h
@@ -17,7 +17,7 @@
 #define JS_STR_VIEWERVARIATION L"Full"
 #define JS_STR_VIEWERVERSION_XFA L"11"
 
-class CFWL_TimerInfo;
+struct CFWL_TimerInfo;
 
 class CXFA_FWLAdapterTimerMgr : public IFWL_AdapterTimerMgr {
  public:
@@ -35,13 +35,12 @@ class CXFA_FWLAdapterTimerMgr : public IFWL_AdapterTimerMgr {
   CPDFDoc_Environment* const m_pEnv;
 };
 
-class CFWL_TimerInfo {
- public:
+struct CFWL_TimerInfo {
   CFWL_TimerInfo() : pTimer(nullptr) {}
-  CFWL_TimerInfo(uint32_t event, IFWL_Timer* timer)
-      : uIDEvent(event), pTimer(timer) {}
+  CFWL_TimerInfo(int32_t event, IFWL_Timer* timer)
+      : idEvent(event), pTimer(timer) {}
 
-  uint32_t uIDEvent;
+  int32_t idEvent;
   IFWL_Timer* pTimer;
 };
 
-- 
cgit v1.2.3