From e75538b44dc0afd1951a29d4574a8bdb11ca336f Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 20 Dec 2017 19:33:20 +0000 Subject: Fix nits in JSEmbedderTest. Change-Id: Ib03ee28f7a52cd5aa53c315402141b3b6cff5e7d Reviewed-on: https://pdfium-review.googlesource.com/21892 Reviewed-by: Henrique Nakashima Commit-Queue: Lei Zhang --- testing/js_embedder_test.cpp | 5 +++-- testing/js_embedder_test.h | 3 +-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/testing/js_embedder_test.cpp b/testing/js_embedder_test.cpp index 064a961049..e9eb70d1ec 100644 --- a/testing/js_embedder_test.cpp +++ b/testing/js_embedder_test.cpp @@ -3,11 +3,12 @@ // found in the LICENSE file. #include "testing/js_embedder_test.h" + #include "third_party/base/ptr_util.h" JSEmbedderTest::JSEmbedderTest() - : m_pArrayBufferAllocator(new FXJS_ArrayBufferAllocator), - m_pIsolate(nullptr) {} + : m_pArrayBufferAllocator(pdfium::MakeUnique()) { +} JSEmbedderTest::~JSEmbedderTest() {} diff --git a/testing/js_embedder_test.h b/testing/js_embedder_test.h index fbec0ea5c9..1f27dbeae6 100644 --- a/testing/js_embedder_test.h +++ b/testing/js_embedder_test.h @@ -6,7 +6,6 @@ #define TESTING_JS_EMBEDDER_TEST_H_ #include -#include #include "fxjs/fxjs_v8.h" #include "testing/embedder_test.h" @@ -25,7 +24,7 @@ class JSEmbedderTest : public EmbedderTest { private: std::unique_ptr m_pArrayBufferAllocator; - v8::Isolate* m_pIsolate; + v8::Isolate* m_pIsolate = nullptr; std::unique_ptr m_Engine; }; -- cgit v1.2.3