From ecc3c836cf6965fbb7ad06b61da87332e59ea5d8 Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Mon, 10 Apr 2017 10:47:18 -0400 Subject: Fix windows skia component build The skia build on Windows is not producing a shared .lib file when building skia. This Cl updates the Skia component build to correctly generate the needed shared library. Bug: pdfium:701 Change-Id: I9545b8fcf76c8622624780ee3cc9ba794f4a842d Reviewed-on: https://pdfium-review.googlesource.com/3971 Reviewed-by: Cary Clark Reviewed-by: Wei Li Commit-Queue: dsinclair --- skia/BUILD.gn | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/skia/BUILD.gn b/skia/BUILD.gn index ef3a9edc5d..31a851d576 100644 --- a/skia/BUILD.gn +++ b/skia/BUILD.gn @@ -37,6 +37,17 @@ config("skia_config") { defines = [] + if (is_win) { + defines += [ "SK_FREETYPE_MINIMUM_RUNTIME_VERSION=(((FREETYPE_MAJOR) * 0x01000000) | ((FREETYPE_MINOR) * 0x00010000) | ((FREETYPE_PATCH) * 0x00000100))" ] + } + + if (is_component_build) { + defines += [ + "SKIA_DLL", + "GR_GL_IGNORE_ES3_MSAA=0", + ] + } + if (skia_support_gpu) { include_dirs += [ "//third_party/skia/include/gpu", @@ -90,6 +101,10 @@ config("skia_library_config") { defines = [] + if (is_component_build) { + defines += [ "SKIA_IMPLEMENTATION=1" ] + } + if (current_cpu == "arm") { if (arm_use_neon) { defines += [ "SK_ARM_HAS_NEON" ] -- cgit v1.2.3