From f6144d4ab76e6357bd8d228ddf542ef4fb3fa3b0 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Mon, 20 Aug 2018 19:07:33 +0000 Subject: Fix reversed arguments to GenerateResourceDict(). GeneratePopupAP() passes [Font Dict, ExtGState Dict] to GenerateResourceDict(), but GenerateResourceDict() is expecting the dictionaries to be the other way around. Change-Id: I2ed21e47edda7979f177be3b6a1030512348c448 Reviewed-on: https://pdfium-review.googlesource.com/37411 Reviewed-by: Ryan Harrison Commit-Queue: Lei Zhang --- core/fpdfdoc/cpvt_generateap.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/fpdfdoc/cpvt_generateap.cpp b/core/fpdfdoc/cpvt_generateap.cpp index 28598c1959..7faa4bfeca 100644 --- a/core/fpdfdoc/cpvt_generateap.cpp +++ b/core/fpdfdoc/cpvt_generateap.cpp @@ -763,8 +763,8 @@ bool GeneratePopupAP(CPDF_Document* pDoc, CPDF_Dictionary* pAnnotDict) { auto pExtGStateDict = GenerateExtGStateDict(*pAnnotDict, sExtGSDictName, "Normal"); - auto pResourceDict = GenerateResourceDict(pDoc, std::move(pResourceFontDict), - std::move(pExtGStateDict)); + auto pResourceDict = GenerateResourceDict(pDoc, std::move(pExtGStateDict), + std::move(pResourceFontDict)); sAppStream << GetPopupContentsString(pDoc, *pAnnotDict, pDefFont, sFontName); GenerateAndSetAPDict(pDoc, pAnnotDict, &sAppStream, std::move(pResourceDict), -- cgit v1.2.3