From fa370ac5cf6472f0ec0c9ecf62d1f9dd20ebfa42 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 23 Jan 2015 15:22:57 -0800 Subject: Fix test naming in previous commit. The embeddertests binary should have source files ending in _embeddertest, not _unittest. TBR=bo_xu@foxitsoftware.com Review URL: https://codereview.chromium.org/871093004 --- BUILD.gn | 2 +- fpdfsdk/src/fpdf_dataavail_embeddertest.cpp | 23 +++++++++++++++++++++++ fpdfsdk/src/fpdf_dataavail_unittest.cpp | 23 ----------------------- pdfium.gyp | 2 +- 4 files changed, 25 insertions(+), 25 deletions(-) create mode 100644 fpdfsdk/src/fpdf_dataavail_embeddertest.cpp delete mode 100644 fpdfsdk/src/fpdf_dataavail_unittest.cpp diff --git a/BUILD.gn b/BUILD.gn index 0822a5ff07..a6ea102294 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -813,7 +813,7 @@ test("pdfium_unittests") { test("pdfium_embeddertests") { sources = [ - "fpdfsdk/src/fpdf_dataavail_unittest.cpp", + "fpdfsdk/src/fpdf_dataavail_embeddertest.cpp", "fpdfsdk/src/fpdfdoc_embeddertest.cpp", "fpdfsdk/src/fpdfview_embeddertest.cpp", "testing/embedder_test.cpp", diff --git a/fpdfsdk/src/fpdf_dataavail_embeddertest.cpp b/fpdfsdk/src/fpdf_dataavail_embeddertest.cpp new file mode 100644 index 0000000000..6081fa52ac --- /dev/null +++ b/fpdfsdk/src/fpdf_dataavail_embeddertest.cpp @@ -0,0 +1,23 @@ +// Copyright 2015 PDFium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "../../testing/embedder_test.h" +#include "../../fpdfsdk/include/fpdfview.h" +#include "../../fpdfsdk/include/fpdfdoc.h" +#include "testing/gtest/include/gtest/gtest.h" + +class FPDFDataAvailEmbeddertest : public EmbedderTest { +}; + +TEST_F(FPDFDataAvailEmbeddertest, TrailerUnterminated) { + // Document must open without crashing but is too malformed to be available. + EXPECT_TRUE(OpenDocument("testing/resources/trailer_unterminated.pdf")); + EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_)); +} + +TEST_F(FPDFDataAvailEmbeddertest, TrailerAsHexstring) { + // Document must open without crashing but is too malformed to be available. + EXPECT_TRUE(OpenDocument("testing/resources/trailer_as_hexstring.pdf")); + EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_)); +} diff --git a/fpdfsdk/src/fpdf_dataavail_unittest.cpp b/fpdfsdk/src/fpdf_dataavail_unittest.cpp deleted file mode 100644 index 6081fa52ac..0000000000 --- a/fpdfsdk/src/fpdf_dataavail_unittest.cpp +++ /dev/null @@ -1,23 +0,0 @@ -// Copyright 2015 PDFium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "../../testing/embedder_test.h" -#include "../../fpdfsdk/include/fpdfview.h" -#include "../../fpdfsdk/include/fpdfdoc.h" -#include "testing/gtest/include/gtest/gtest.h" - -class FPDFDataAvailEmbeddertest : public EmbedderTest { -}; - -TEST_F(FPDFDataAvailEmbeddertest, TrailerUnterminated) { - // Document must open without crashing but is too malformed to be available. - EXPECT_TRUE(OpenDocument("testing/resources/trailer_unterminated.pdf")); - EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_)); -} - -TEST_F(FPDFDataAvailEmbeddertest, TrailerAsHexstring) { - // Document must open without crashing but is too malformed to be available. - EXPECT_TRUE(OpenDocument("testing/resources/trailer_as_hexstring.pdf")); - EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_)); -} diff --git a/pdfium.gyp b/pdfium.gyp index e9c958c703..eedbe5da37 100644 --- a/pdfium.gyp +++ b/pdfium.gyp @@ -838,7 +838,7 @@ '<(DEPTH)' ], 'sources': [ - 'fpdfsdk/src/fpdf_dataavail_unittest.cpp', + 'fpdfsdk/src/fpdf_dataavail_embeddertest.cpp', 'fpdfsdk/src/fpdfdoc_embeddertest.cpp', 'fpdfsdk/src/fpdfview_embeddertest.cpp', 'testing/embedder_test.cpp', -- cgit v1.2.3