From 76833a60164e77bd54c6f4d1cc62a79ded8edb90 Mon Sep 17 00:00:00 2001
From: Lei Zhang <thestig@chromium.org>
Date: Fri, 12 Oct 2018 18:53:17 +0000
Subject: Split constants and testing build rules into their own BUILD.gn
 files.

Change-Id: I3a100e1f009f18ee06959edf47d189d1bfdcb25a
Reviewed-on: https://pdfium-review.googlesource.com/c/43944
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
---
 BUILD.gn | 65 +++++-----------------------------------------------------------
 1 file changed, 5 insertions(+), 60 deletions(-)

(limited to 'BUILD.gn')

diff --git a/BUILD.gn b/BUILD.gn
index aa676b76d6..068d41249c 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -142,7 +142,6 @@ jumbo_static_library("pdfium") {
   configs += [ ":pdfium_core_config" ]
 
   deps = [
-    ":constants",
     ":fdrm",
     ":fpdfapi",
     ":fpdfdoc",
@@ -150,6 +149,7 @@ jumbo_static_library("pdfium") {
     ":fxcodec",
     ":fxcrt",
     ":fxge",
+    "constants",
     "fpdfsdk",
     "fpdfsdk/formfiller",
     "fpdfsdk/pwl",
@@ -183,52 +183,6 @@ jumbo_static_library("pdfium") {
   }
 }
 
-jumbo_source_set("test_support") {
-  testonly = true
-  sources = [
-    "testing/fx_string_testhelpers.cpp",
-    "testing/fx_string_testhelpers.h",
-    "testing/string_write_stream.cpp",
-    "testing/string_write_stream.h",
-    "testing/test_support.cpp",
-    "testing/test_support.h",
-    "testing/utils/bitmap_saver.cpp",
-    "testing/utils/bitmap_saver.h",
-    "testing/utils/path_service.cpp",
-    "testing/utils/path_service.h",
-  ]
-  data = [
-    "testing/resources/",
-  ]
-  deps = [
-    ":image_diff",
-    ":pdfium",
-    "//testing/gmock",
-    "//testing/gtest",
-  ]
-  include_dirs = []
-  if (pdf_enable_v8) {
-    deps += [
-      "//v8",
-      "//v8:v8_libplatform",
-    ]
-    configs += [ "//v8:external_startup_data" ]
-  }
-  configs += [ ":pdfium_core_config" ]
-}
-
-jumbo_source_set("image_diff") {
-  testonly = true
-  sources = [
-    "testing/image_diff/image_diff_png.cpp",
-    "testing/image_diff/image_diff_png.h",
-  ]
-  configs += [ ":pdfium_core_config" ]
-  deps = [
-    "third_party:png",
-  ]
-}
-
 # Targets below this are only visible within this file (and to the
 # top-level gn_visibility target used to help gn_all build everything).
 visibility = [
@@ -236,15 +190,6 @@ visibility = [
   "//:gn_visibility",
 ]
 
-jumbo_source_set("constants") {
-  sources = [
-    "constants/form_flags.h",
-    "constants/page_object.h",
-    "constants/stream_dict_common.h",
-    "constants/transparency.h",
-  ]
-}
-
 jumbo_source_set("fdrm") {
   sources = [
     "core/fdrm/crypto/fx_crypt.cpp",
@@ -1187,7 +1132,7 @@ test("pdfium_unittests") {
   ]
   deps = [
     ":pdfium",
-    ":test_support",
+    "testing/:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
@@ -1299,9 +1244,9 @@ test("pdfium_embeddertests") {
     "testing/range_set.h",
   ]
   deps = [
-    ":image_diff",
     ":pdfium",
-    ":test_support",
+    "testing/:test_support",
+    "testing/image_diff",
     "//testing/gmock",
     "//testing/gtest",
   ]
@@ -1347,8 +1292,8 @@ if (pdf_is_standalone) {
       "testing/image_diff/image_diff.cpp",
     ]
     deps = [
-      ":image_diff",
       ":pdfium",
+      "testing/image_diff",
       "//build/win:default_exe_manifest",
     ]
     configs -= [ "//build/config/compiler:chromium_code" ]
-- 
cgit v1.2.3