From 8b4a3c7ef32b2ffb4874e4cc65b38ee555d8806e Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Tue, 17 Apr 2018 17:59:58 +0000 Subject: Use span in CXFA_LocaleValue::GetDoubleNum() Get runtime checks instead of just asserts. Use early return while at it to save some indentation. Fix one out-of-bounds case noted by inspection. Add tests, and fix bugs that gave the wrong answers. This should be removed at our earliest convenience. Its likely to still be wrong. Change-Id: I2a68edc854c8b28c434fe28397b7834e5c9c3670 Reviewed-on: https://pdfium-review.googlesource.com/30530 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- BUILD.gn | 1 + 1 file changed, 1 insertion(+) (limited to 'BUILD.gn') diff --git a/BUILD.gn b/BUILD.gn index e78b2cf6e4..c00557594b 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -2929,6 +2929,7 @@ test("pdfium_unittests") { "xfa/fxfa/fm2js/cxfa_fmlexer_unittest.cpp", "xfa/fxfa/fm2js/cxfa_fmparser_unittest.cpp", "xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp", + "xfa/fxfa/parser/cxfa_localevalue_unittest.cpp", "xfa/fxfa/parser/cxfa_node_unittest.cpp", "xfa/fxfa/parser/cxfa_nodeiteratortemplate_unittest.cpp", "xfa/fxfa/parser/cxfa_xmllocale_unittest.cpp", -- cgit v1.2.3