From 23a5d7ea73f11ffac00239305e67c1bb46409878 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 14 Mar 2017 15:01:29 -0400 Subject: Convert CPDF_Creator::m_Pos to uint32_t Currently m_Pos is a FX_POSITION. The value stored into the void* is typically a uint32_t. We sometimes read that uint32_t value as a size_t to compare against vector lengths. This Cl converts all usages to be uint32_t and uses pdfium::CollectionSize to get the correct typed vector size. Change-Id: I5f452817ab6049e03477945e4622c6911c89f877 Reviewed-on: https://pdfium-review.googlesource.com/3032 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- core/fpdfapi/edit/cpdf_creator.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'core/fpdfapi/edit/cpdf_creator.h') diff --git a/core/fpdfapi/edit/cpdf_creator.h b/core/fpdfapi/edit/cpdf_creator.h index 0840e4b7a6..ba5a7439fa 100644 --- a/core/fpdfapi/edit/cpdf_creator.h +++ b/core/fpdfapi/edit/cpdf_creator.h @@ -90,9 +90,10 @@ class CPDF_Creator { uint32_t m_dwLastObjNum; CFX_FileBufferArchive m_File; FX_FILESIZE m_Offset; + FX_FILESIZE m_SavedOffset; int32_t m_iStage; uint32_t m_dwFlags; - FX_POSITION m_Pos; + uint32_t m_CurObjNum; FX_FILESIZE m_XrefStart; CFX_FileSizeListArray m_ObjectOffset; std::vector m_NewObjNumArray; // Sorted, ascending. -- cgit v1.2.3