From aaaf9877478d7add8a74b4db74d97ca19ce1c47e Mon Sep 17 00:00:00 2001 From: Henrique Nakashima Date: Thu, 21 Jun 2018 19:12:24 +0000 Subject: Use enum for stages of CPDF_Creator. Change-Id: Ic750e04a24524d47ba77b9b7cd5a29605965f68b Reviewed-on: https://pdfium-review.googlesource.com/35390 Commit-Queue: Henrique Nakashima Reviewed-by: dsinclair --- core/fpdfapi/edit/cpdf_creator.h | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) (limited to 'core/fpdfapi/edit/cpdf_creator.h') diff --git a/core/fpdfapi/edit/cpdf_creator.h b/core/fpdfapi/edit/cpdf_creator.h index 9c760edeae..079f1c2666 100644 --- a/core/fpdfapi/edit/cpdf_creator.h +++ b/core/fpdfapi/edit/cpdf_creator.h @@ -38,16 +38,33 @@ class CPDF_Creator { bool SetFileVersion(int32_t fileVersion); private: - int32_t Continue(); + enum class Stage { + kInvalid = -1, + kInit0 = 0, + kWriteHeader10 = 10, + kWriteIncremental15 = 15, + kInitWriteObjs20 = 20, + kWriteOldObjs21 = 21, + kInitWriteNewObjs25 = 25, + kWriteNewObjs26 = 26, + kWriteEncryptDict27 = 27, + kInitWriteXRefs80 = 80, + kWriteXrefsNotIncremental81 = 81, + kWriteXrefsIncremental82 = 82, + kWriteTrailerAndFinish90 = 90, + kComplete100 = 100, + }; + + bool Continue(); void Clear(); void InitNewObjNumOffsets(); void InitID(); - int32_t WriteDoc_Stage1(); - int32_t WriteDoc_Stage2(); - int32_t WriteDoc_Stage3(); - int32_t WriteDoc_Stage4(); + CPDF_Creator::Stage WriteDoc_Stage1(); + CPDF_Creator::Stage WriteDoc_Stage2(); + CPDF_Creator::Stage WriteDoc_Stage3(); + CPDF_Creator::Stage WriteDoc_Stage4(); bool WriteOldIndirectObject(uint32_t objnum); bool WriteOldObjs(); @@ -67,7 +84,7 @@ class CPDF_Creator { uint32_t m_dwLastObjNum; std::unique_ptr m_Archive; FX_FILESIZE m_SavedOffset = 0; - int32_t m_iStage = -1; + Stage m_iStage = Stage::kInvalid; uint32_t m_CurObjNum = 0; FX_FILESIZE m_XrefStart = 0; std::map m_ObjectOffsets; -- cgit v1.2.3