From 55865454c43fbc3b163cff166544ba0a060dcbc4 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Aug 2018 20:18:04 +0000 Subject: The final game: mark everything final. Then revert the ones that break compilation. Fix one IWYU noticed during presubmit. Change-Id: I881a8a72818e55dbc4816247e35ff5e3015194e7 Reviewed-on: https://pdfium-review.googlesource.com/41470 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- core/fpdfapi/edit/cpdf_creator.cpp | 2 +- core/fpdfapi/edit/cpdf_creator_embeddertest.cpp | 2 +- core/fpdfapi/edit/cpdf_stringarchivestream.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'core/fpdfapi/edit') diff --git a/core/fpdfapi/edit/cpdf_creator.cpp b/core/fpdfapi/edit/cpdf_creator.cpp index 11b0628b01..7af62806da 100644 --- a/core/fpdfapi/edit/cpdf_creator.cpp +++ b/core/fpdfapi/edit/cpdf_creator.cpp @@ -28,7 +28,7 @@ namespace { const size_t kArchiveBufferSize = 32768; -class CFX_FileBufferArchive : public IFX_ArchiveStream { +class CFX_FileBufferArchive final : public IFX_ArchiveStream { public: explicit CFX_FileBufferArchive(const RetainPtr& archive); ~CFX_FileBufferArchive() override; diff --git a/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp b/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp index 2d431b8424..1f8f788d34 100644 --- a/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp +++ b/core/fpdfapi/edit/cpdf_creator_embeddertest.cpp @@ -20,7 +20,7 @@ namespace { -class FileAccess : public FPDF_FILEACCESS { +class FileAccess final : public FPDF_FILEACCESS { public: explicit FileAccess(const std::string& file_name) { std::string file_path; diff --git a/core/fpdfapi/edit/cpdf_stringarchivestream.h b/core/fpdfapi/edit/cpdf_stringarchivestream.h index bb5481e376..aa744a9ea1 100644 --- a/core/fpdfapi/edit/cpdf_stringarchivestream.h +++ b/core/fpdfapi/edit/cpdf_stringarchivestream.h @@ -7,7 +7,7 @@ #include "core/fxcrt/fx_stream.h" -class CPDF_StringArchiveStream : public IFX_ArchiveStream { +class CPDF_StringArchiveStream final : public IFX_ArchiveStream { public: explicit CPDF_StringArchiveStream(std::ostringstream* stream); ~CPDF_StringArchiveStream() override; -- cgit v1.2.3