From 868150bd69f0f1f9472affc20deea0a9341bf22b Mon Sep 17 00:00:00 2001 From: weili Date: Mon, 13 Jun 2016 14:57:29 -0700 Subject: Make code compile with clang_use_chrome_plugin (part I) This change contains files in core/fpdfapi directory. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups; BUG=pdfium:469 Review-Url: https://codereview.chromium.org/2060973002 --- core/fpdfapi/fpdf_page/cpdf_pagemodule.h | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'core/fpdfapi/fpdf_page/cpdf_pagemodule.h') diff --git a/core/fpdfapi/fpdf_page/cpdf_pagemodule.h b/core/fpdfapi/fpdf_page/cpdf_pagemodule.h index c609de9c58..2e418f8993 100644 --- a/core/fpdfapi/fpdf_page/cpdf_pagemodule.h +++ b/core/fpdfapi/fpdf_page/cpdf_pagemodule.h @@ -15,16 +15,12 @@ class CPDF_Document; class CPDF_PageModule { public: - CPDF_PageModule() - : m_StockGrayCS(nullptr, PDFCS_DEVICEGRAY), - m_StockRGBCS(nullptr, PDFCS_DEVICERGB), - m_StockCMYKCS(nullptr, PDFCS_DEVICECMYK), - m_StockPatternCS(nullptr) {} - ~CPDF_PageModule() {} - - CPDF_FontGlobals* GetFontGlobals() { return &m_FontGlobals; } + CPDF_PageModule(); + ~CPDF_PageModule(); + + CPDF_FontGlobals* GetFontGlobals(); CPDF_ColorSpace* GetStockCS(int family); - void ClearStockFont(CPDF_Document* pDoc) { m_FontGlobals.Clear(pDoc); } + void ClearStockFont(CPDF_Document* pDoc); private: CPDF_FontGlobals m_FontGlobals; -- cgit v1.2.3