From 822484b5f88d92dbcd567b1c2da38af1e720b56f Mon Sep 17 00:00:00 2001 From: tsepez Date: Mon, 11 Apr 2016 18:14:56 -0700 Subject: Remove CPDF_Object::GetConstString and overrides GetConstString() has sharp edges in that when applied to a CPDF_Number, it must return null whereas GetString() returns a the stringified number, because of the inability to control the lifetime of the underlying allocated string. Deleting this method showed several places where we actually wanted a *String, not a *StringC, so we were re-allocating a string we already had. Review URL: https://codereview.chromium.org/1879683002 --- core/fpdfapi/fpdf_parser/cpdf_name.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'core/fpdfapi/fpdf_parser/cpdf_name.cpp') diff --git a/core/fpdfapi/fpdf_parser/cpdf_name.cpp b/core/fpdfapi/fpdf_parser/cpdf_name.cpp index d641374547..2999772aec 100644 --- a/core/fpdfapi/fpdf_parser/cpdf_name.cpp +++ b/core/fpdfapi/fpdf_parser/cpdf_name.cpp @@ -28,10 +28,6 @@ CFX_ByteString CPDF_Name::GetString() const { return m_Name; } -CFX_ByteStringC CPDF_Name::GetConstString() const { - return m_Name.AsStringC(); -} - void CPDF_Name::SetString(const CFX_ByteString& str) { m_Name = str; } -- cgit v1.2.3