From 12168d764be266a209bc3fd15dbe4223732ae319 Mon Sep 17 00:00:00 2001 From: thestig Date: Tue, 26 Apr 2016 22:41:36 -0700 Subject: CPDF_Document::LoadPattern() and friends always have a valid matrix. So pass by const-ref instead of by pointer. Review URL: https://codereview.chromium.org/1923153002 --- core/fpdfapi/fpdf_parser/cpdf_document.cpp | 2 +- core/fpdfapi/fpdf_parser/include/cpdf_document.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'core/fpdfapi/fpdf_parser') diff --git a/core/fpdfapi/fpdf_parser/cpdf_document.cpp b/core/fpdfapi/fpdf_parser/cpdf_document.cpp index c92e177dcc..ead1ac0455 100644 --- a/core/fpdfapi/fpdf_parser/cpdf_document.cpp +++ b/core/fpdfapi/fpdf_parser/cpdf_document.cpp @@ -753,7 +753,7 @@ CPDF_ColorSpace* CPDF_Document::LoadColorSpace(CPDF_Object* pCSObj, CPDF_Pattern* CPDF_Document::LoadPattern(CPDF_Object* pPatternObj, FX_BOOL bShading, - const CFX_Matrix* matrix) { + const CFX_Matrix& matrix) { return m_pDocPage->GetPattern(pPatternObj, bShading, matrix); } diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_document.h b/core/fpdfapi/fpdf_parser/include/cpdf_document.h index 38c0fdda30..687619b763 100644 --- a/core/fpdfapi/fpdf_parser/include/cpdf_document.h +++ b/core/fpdfapi/fpdf_parser/include/cpdf_document.h @@ -70,7 +70,7 @@ class CPDF_Document : public CFX_PrivateData, public CPDF_IndirectObjectHolder { CPDF_Pattern* LoadPattern(CPDF_Object* pObj, FX_BOOL bShading, - const CFX_Matrix* matrix = NULL); + const CFX_Matrix& matrix); CPDF_Image* LoadImageF(CPDF_Object* pObj); CPDF_StreamAcc* LoadFontFile(CPDF_Stream* pStream); -- cgit v1.2.3